From b2c9f98f77c1ab673c2937321014f075549f0e7d Mon Sep 17 00:00:00 2001 From: Ben Woosley Date: Fri, 20 Jul 2018 12:59:24 -0400 Subject: [PATCH] fix: only generate a new address on new incoming transaction Outgoing transactions reference a historical utxo, and do not tie information to the current receive address, so don't call for generating a new one. --- app/reducers/transaction.js | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/app/reducers/transaction.js b/app/reducers/transaction.js index 2e3e4fcd..3f65d025 100644 --- a/app/reducers/transaction.js +++ b/app/reducers/transaction.js @@ -132,17 +132,18 @@ export const newTransaction = (event, { transaction }) => (dispatch, getState) = dispatch({ type: ADD_TRANSACTION, transaction }) // HTML 5 desktop notification for the new transaction - const notifTitle = transaction.received - ? 'On-chain Transaction Received!' - : 'On-chain Transaction Sent!' - const notifBody = transaction.received - ? "Lucky you, you just received a new on-chain transaction. I'm jealous." - : "Hate to see 'em go but love to watch 'em leave. Your on-chain transaction successfully sent." - - showNotification(notifTitle, notifBody) - - // Generate a new address - dispatch(newAddress('np2wkh')) + if (transaction.received) { + showNotification( + 'On-chain Transaction Received!', + "Lucky you, you just received a new on-chain transaction. I'm jealous." + ) + dispatch(newAddress('np2wkh')) // Generate a new address + } else { + showNotification( + 'On-chain Transaction Sent!', + "Hate to see 'em go but love to watch 'em leave. Your on-chain transaction successfully sent." + ) + } } }