Ben Woosley
2cebba7a57
enhance(linting): Enable the eslint:recommended rules
Among other things, this makes no-console an error rather than a warning.
https://eslint.org/docs/rules/no-console
Given that we now have a proper logging facility, good to prevent incidental
introduction in the future.
7 years ago
Jack Mallers
3a1d008466
fix(lint): fix lint errors
7 years ago
Jack Mallers
1f9a316326
fix(lint): fix linting errors
7 years ago
Jack Mallers
357cf4e0ef
fix(lint): fix all lint errors except a few (will fix the rest after i finish the rest of the modals)
7 years ago
Jack Mallers
dc4e03fa8c
fix(lint): update lint packages + config
7 years ago
Ben Woosley
313078cfc6
fix(eslint-promise): Enable the recommended eslint-plugin-promise config
And fix related errors.
I extracted ensurePeerConnected from connectAndOpen to solve some code
duplication.
7 years ago
Ben Woosley
a1194a8171
enhance(eslint-a11y): Enable the strict jsx-a11y
We're currently passing these, apart from those explicitly disabled.
https://www.npmjs.com/package/eslint-plugin-jsx-a11y#difference-between-recommended-and-strict-mode
7 years ago
Ben Woosley
8e06ad5105
fix(eslint-import): Fix that eslint-plugin-import was not active
For the node import resolver, "paths" is meant to be absolute paths
for global modules.
https://github.com/benmosher/eslint-plugin-import/tree/master/resolvers/node
7 years ago
Ben Woosley
38d9a97513
fix(eslint-flowtype-errors): Enable flowtype-errors linters
Including enforce-min-coverage set to the current lowest flow coverage.
7 years ago
Ben Woosley
e110e0112c
fix(eslint-flowtypes): Enable plugin:flowtype/recommended
Ignore all of flow-typed
The module_vx.x.x.js's purpose is mysterious and it's causing lint failures on
CI. Excluding it seems reasonable.
7 years ago
Ben Woosley
0e05b79664
fix(eslint-compat): Enable eslint compat rules
Note the compat rules enabled are based on browserlist in package.json
7 years ago
Ben Woosley
b3a4a3683c
fix(react-eslint): Enable the recommended react eslint rules
Previously was included but not enabled. The errors fixed are:
app/routes.js:9:16
✖ 9:16 Component definition is missing display name react/display-name
app/routes/contacts/components/Contacts.js:151:49
✖ 151:49 Missing "key" prop for element in iterator react/jsx-key
✖ 167:22 Missing "key" prop for element in iterator react/jsx-key
7 years ago
Jack Mallers
962d79bb88
fix(lint): fix linting errors
7 years ago
Jack Mallers
e793efa1ed
fix(lint): fix linting errors
7 years ago
Torkel Rogstad
ef54915c11
Removes unused code, adds proper semicolon rule and reduces lint errors
7 years ago
Jonathan Zobro
56497e4b5a
add baseline tests to component/Peers, use 'app/node_modules' in eslintrc to import app specific node_modules
7 years ago
Jonathan Zobro
15d0a76662
feature(eslint-resolve-paths-from-app-dir): use 'app' path as default for imports
7 years ago
Jack Mallers
15eacc7f47
fix(lint): fix eslint errors
7 years ago
Jack Mallers
88c577d248
fix(lint): fix all lint errors/warnings
8 years ago
Jack Mallers
393a34c7e8
fix(lint): fix more linting errors
8 years ago
Jack Mallers
abb1b02a36
fix(lint): start fixing linting error
8 years ago
Jack Mallers
85485bb5eb
first commit
8 years ago