Refactor Containers and Routes in order to make the code a little more
readable, reduce duplication, and prepare the codebase for integration
of the new Home screen.
- Break out the Root container into several smaller containers that are
responsible for connecting themselves to the Redux store.
- Use routing for navigation between primary containers
- Unbundle the `Syncing` Component from the Onboarding section and hook
up to router so that it can be access by navigating to `/syncing' (we
want to be able to load existing wallets and initiate syncing outside of
the context of the onboarding process)
- Reduce code duplication
- Create `TitleBar` component and implement once at the top level
- Create `withLoading` HOC and use to display the loading screen when
needed.
Select free ports for lnd from a pool of options. By default we will
use the standard lnd ports (10009 and 9735) but if those are not
available then we will search for free ports in a nearby range.
This allows us to have multiple instances of the wallet running and
avoids possible conflicts with other instances of lnd that the user
may be running.
Coverage tests are only relevant for the unit tests and do not work in
the context of the e2e test suite. Only generate coverage reports
for the unit tests.
Jest is sometimes unable to detect when tests have completed which can
result in tests hanging indefinitely, which breaks our CI builds on
Appveyor.
This is a know issue in jest and they added a `forceExit` in order to
help users facing this issue.
See https://github.com/facebook/jest/issues/1456
The detectOpenHandles flag was added to help pin down an issue that we
were facing with some of our tests a while back. This flag comes with a
very high performance penalty and is no longer needed in our setup.
The txt coverage reporter generates a lot of output that makes it hard
to see the actual test results without scrolling up a lot first.
We already have the html reporter setup and an npm script to enable
easy viewing of the data (`yarn coverage`) so the text reporter isn't
adding anything useful.
There is no need to check wether an lnd process exists and prevent
Zap from starting if so. We don't care if there is another process
running. We only care that we can successfully start up our own process.
If there is a conflict with another lnd process such as a port that we
need already being in use we already handle this elsewhere in our code.
Tom Kirkpatrick
Tom Kirkpatrick