There is an unneeded call to `concurrently` in the `npm run dev` script.
This causes things that should be output in colour (eg debug messages
when running with DEBUG=*) to not be output in colour which makes
debugging things harder than it should be.
This was in place because previously lnd was being started up externally
in the `npm run dev` script at the same time as starting up the app. But
we now use spawn from within the app to start up lnd.
The call to `concurrently` is no longer needed.
See d8c5623e01
Update all webpack packages to the latest v4.x compatible versions and
update supporting configs. This delivers noticeable performance
improvements to the DX.
The v5.2.0 includes (amongst other things) a fix for incorrectly reported
exit codes of child processes, which can prevent build build failures from
correctly halting a build, resulting in incomplete or invalid builds.
See https://github.com/kentcdodds/cross-env/issues/150#issuecomment-387737183
Update webpack and related packages to the latest 3.x versions. This
prevents errors from node-gyp when attempting to build fsevents (OSX),
which is an indirect dependency of webpack-dev-server (via chokidir)
See https://github.com/strongloop/fsevents/releases/tag/v1.1.0
The v20.15.1 release of electron-builder has been unpublished since its
original release and subsequently a newer v20.15.3 version has been
released. v20.15.3 resolves several critical issues found in v20.15.1,
one of which was causing `electron-builder install-app-deps` to hang
indefinitely when run without `DEBUG=electron-builder` being set
Update grpc to v1.12.3 in order to fix issues build issues due to the fact
that 1.12.1 doesn't contain node-pre-gyp as a bundled dependency.
See https://github.com/grpc/grpc-node/issues/365
The latest version of electron-builder lets us use file macros in the file
patterns such as `$platform`, which is useful for us to be able to
include platform specific files in the build as DRY as possible.
Only one of these files was being used, and they were going out of step
relative to one another.
Put rpc.proto in the resources directory for consistency with other
vendored resources, i.e. the lnd binary
Updated the def from:
https://github.com/lightningnetwork/lnd/blob/master/lnrpc/rpc.proto
From stylefmt's readme:
Consider other tools before adopting stylefmt
If you are using stylefmt with stylelint configuration to format according
to its rules, you can now use stylelint's --fix option (from v7.11.0) to autofix.
And declare minimum versions in package.json.
Node 7 was a dev release and is defunct now that 8 is LTS and 9 is the
current dev release. If we wanted to support earlier versions, we should
go all the way back to the prior LTS release series, 6, but I don't see
a reason to do that for new software.
Bump to npm 5 because that is the version that was released with node 8:
https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V8.md#8.0.0
This was prompted by the fact that current versions of yarn have dropped node 7
support.
https://yarnpkg.com/en/
It's used by flow:
Launching Flow server for /.../zap-desktop
Spawned flow server (pid=46193)
Logs will go to /private/tmp/flow/zSUserszSbenzSDevelopmentzSBitcoinzSzZap-desktop.log
app/main.dev.js:18
18: import { lookup } from 'ps-node'
^^^^^^^^^ ps-node. Required module not found
Found 1 error
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! zap-desktop@0.0.1 flow: `flow`
npm ERR! Exit status 2
Tom Kirkpatrick
Ben Woosley
Jack Mallers
João Almeida
Jim Posen