TST: fix

class/hd-segwit-bech32-wallet.js

@@ -294,7 +294,7 @@ export class HDSegwitBech32Wallet extends AbstractHDWallet {
     for (let c = 0; c < this.next_free_address_index + this.gap_limit; c++) {
       for (let tx of Object.values(txdatas)) {
         for (let vin of tx.vin) {
-          if (vin.addresses.indexOf(this._getExternalAddressByIndex(c)) !== -1) {
+          if (vin.addresses && vin.addresses.indexOf(this._getExternalAddressByIndex(c)) !== -1) {
             // this TX is related to our address
             this._txs_by_external_index[c] = this._txs_by_external_index[c] || [];
             let clonedTx = Object.assign({}, tx);
@@ -341,7 +341,7 @@ export class HDSegwitBech32Wallet extends AbstractHDWallet {
     for (let c = 0; c < this.next_free_change_address_index + this.gap_limit; c++) {
       for (let tx of Object.values(txdatas)) {
         for (let vin of tx.vin) {
-          if (vin.addresses.indexOf(this._getInternalAddressByIndex(c)) !== -1) {
+          if (vin.addresses && vin.addresses.indexOf(this._getInternalAddressByIndex(c)) !== -1) {
             // this TX is related to our address
             this._txs_by_internal_index[c] = this._txs_by_internal_index[c] || [];
             let clonedTx = Object.assign({}, tx);

tests/integration/Electrum.test.js

@@ -193,6 +193,19 @@ describe('Electrum', () => {
     assert.ok(Object.keys(txdatas).length === 4);
   });
 
+  it.skip('multiGetTransactionByTxid() can work with huge tx', async () => {
+    // electrum cant return verbose output because of "response too large (over 1,000,000 bytes"
+    // for example:
+    // echo '[{"jsonrpc":"2.0","method":"blockchain.transaction.get","params":["484a11c5e086a281413b9192b4f60c06abf745f08c2c28c4b4daefe6df3b9e5c", true],"id":1}]' | nc bitkoins.nl  50001 -i 1
+    // @see https://electrumx.readthedocs.io/en/latest/protocol-methods.html#blockchain-transaction-get
+    //
+    // possible solution: fetch it without verbose and decode locally. unfortunatelly it omits such info as confirmations, time etc
+    // so whoever uses it should be prepared for this.
+    // tbh consumer wallets dont usually work with such big txs, so probably we dont need it
+    let txdatas = await BlueElectrum.multiGetTransactionByTxid(['484a11c5e086a281413b9192b4f60c06abf745f08c2c28c4b4daefe6df3b9e5c']);
+    assert.ok(txdatas['484a11c5e086a281413b9192b4f60c06abf745f08c2c28c4b4daefe6df3b9e5c']);
+  });
+
   it('ElectrumClient can do multiGetHistoryByAddress() to obtain txhex', async () => {
     let txdatas = await BlueElectrum.multiGetTransactionByTxid(
       ['881c54edd95cbdd1583d6b9148eb35128a47b64a2e67a5368a649d6be960f08e'],