Merge pull request #258 from dcousens/wallclean

Wallet clean

src/wallet.js

@@ -5,32 +5,35 @@ var networks = require('./networks')
 var Address = require('./address')
 var HDNode = require('./hdnode')
 var Transaction = require('./transaction')
+var Script = require('./script')
 
-function Wallet(seed, network) {
+function Wallet(seed, network, unspents) {
+  seed = seed || crypto.randomBytes(32)
   network = network || networks.bitcoin
 
   // Stored in a closure to make accidental serialization less likely
-  var masterkey = null
-  var me = this
-  var accountZero = null
-  var internalAccount = null
-  var externalAccount = null
+  var masterKey = HDNode.fromSeedBuffer(seed, network)
+
+  // HD first-level child derivation method should be hardened
+  // See https://bitcointalk.org/index.php?topic=405179.msg4415254#msg4415254
+  var accountZero = masterKey.deriveHardened(0)
+  var externalAccount = accountZero.derive(0)
+  var internalAccount = accountZero.derive(1)
 
-  // Addresses
   this.addresses = []
   this.changeAddresses = []
+  this.network = network
+  this.outputs = unspents ? processUnspentOutputs(unspents) : {}
 
-  // Transaction output data
-  this.outputs = {}
-
-  // Make a new master key
+  // FIXME: remove in 2.x.y
+  var me = this
   this.newMasterKey = function(seed) {
+    console.warn('newMasterKey is deprecated, please make a new Wallet instance instead')
+
     seed = seed || crypto.randomBytes(32)
-    masterkey = HDNode.fromSeedBuffer(seed, network)
+    masterKey = HDNode.fromSeedBuffer(seed, network)
 
-    // HD first-level child derivation method should be hardened
-    // See https://bitcointalk.org/index.php?topic=405179.msg4415254#msg4415254
-    accountZero = masterkey.deriveHardened(0)
+    accountZero = masterKey.deriveHardened(0)
     externalAccount = accountZero.derive(0)
     internalAccount = accountZero.derive(1)
 
@@ -40,196 +43,206 @@ function Wallet(seed, network) {
     me.outputs = {}
   }
 
-  this.newMasterKey(seed)
+  this.getMasterKey = function() { return masterKey }
+  this.getAccountZero = function() { return accountZero }
+  this.getExternalAccount = function() { return externalAccount }
+  this.getInternalAccount = function() { return internalAccount }
+}
 
-  this.generateAddress = function() {
-    var key = externalAccount.derive(this.addresses.length)
-    this.addresses.push(key.getAddress().toString())
-    return this.addresses[this.addresses.length - 1]
-  }
+Wallet.prototype.createTx = function(to, value, fixedFee, changeAddress) {
+  assert(value > this.network.dustThreshold, value + ' must be above dust threshold (' + this.network.dustThreshold + ' Satoshis)')
 
-  this.generateChangeAddress = function() {
-    var key = internalAccount.derive(this.changeAddresses.length)
-    this.changeAddresses.push(key.getAddress().toString())
-    return this.changeAddresses[this.changeAddresses.length - 1]
-  }
+  var utxos = getCandidateOutputs(this.outputs, value)
+  var accum = 0
+  var subTotal = value
+  var addresses = []
 
-  this.getBalance = function() {
-    return this.getUnspentOutputs().reduce(function(memo, output){
-      return memo + output.value
-    }, 0)
-  }
+  var tx = new Transaction()
+  tx.addOutput(to, value)
 
-  this.getUnspentOutputs = function() {
-    var utxo = []
+  for (var i = 0; i < utxos.length; ++i) {
+    var utxo = utxos[i]
+    addresses.push(utxo.address)
 
-    for(var key in this.outputs){
-      var output = this.outputs[key]
-      if(!output.to) utxo.push(outputToUnspentOutput(output))
+    var outpoint = utxo.from.split(':')
+    tx.addInput(outpoint[0], parseInt(outpoint[1]))
+
+    var fee = fixedFee == undefined ? estimatePaddedFee(tx, this.network) : fixedFee
+
+    accum += utxo.value
+    subTotal = value + fee
+    if (accum >= subTotal) {
+      var change = accum - subTotal
+
+      if (change > this.network.dustThreshold) {
+        tx.addOutput(changeAddress || this.getChangeAddress(), change)
       }
 
-    return utxo
+      break
+    }
   }
 
-  this.setUnspentOutputs = function(utxo) {
-    var outputs = {}
+  assert(accum >= subTotal, 'Not enough funds (incl. fee): ' + accum + ' < ' + subTotal)
 
-    utxo.forEach(function(uo){
-      validateUnspentOutput(uo)
-      var o = unspentOutputToOutput(uo)
-      outputs[o.from] = o
-    })
+  this.signWith(tx, addresses)
+  return tx
+}
 
-    this.outputs = outputs
-  }
+Wallet.prototype.processPendingTx = function(tx){
+  processTx.bind(this)(tx, true)
+}
 
-  function outputToUnspentOutput(output){
-    var hashAndIndex = output.from.split(":")
+Wallet.prototype.processConfirmedTx = function(tx){
+  processTx.bind(this)(tx, false)
+}
 
-    return {
-      hash: hashAndIndex[0],
-      outputIndex: parseInt(hashAndIndex[1]),
-      address: output.address,
-      value: output.value,
-      pending: output.pending
-    }
-  }
+Wallet.prototype.generateAddress = function() {
+  var k = this.addresses.length
+  var address = this.getExternalAccount().derive(k).getAddress()
 
-  function unspentOutputToOutput(o) {
-    var hash = o.hash
-    var key = hash + ":" + o.outputIndex
-    return {
-      from: key,
-      address: o.address,
-      value: o.value,
-      pending: o.pending
-    }
-  }
+  this.addresses.push(address.toString())
 
-  function validateUnspentOutput(uo) {
-    var missingField
+  return this.getReceiveAddress()
+}
 
-    if (isNullOrUndefined(uo.hash)) {
-      missingField = "hash"
-    }
+Wallet.prototype.generateChangeAddress = function() {
+  var k = this.changeAddresses.length
+  var address = this.getInternalAccount().derive(k).getAddress()
 
-    var requiredKeys = ['outputIndex', 'address', 'value']
-    requiredKeys.forEach(function (key) {
-      if (isNullOrUndefined(uo[key])){
-        missingField = key
-      }
-    })
+  this.changeAddresses.push(address.toString())
 
-    if (missingField) {
-      var message = [
-        'Invalid unspent output: key', missingField, 'is missing.',
-        'A valid unspent output must contain'
-      ]
-      message.push(requiredKeys.join(', '))
-      message.push("and hash")
-      throw new Error(message.join(' '))
-    }
-  }
+  return this.getChangeAddress()
+}
 
-  function isNullOrUndefined(value) {
-    return value == undefined
-  }
+Wallet.prototype.getBalance = function() {
+  return this.getUnspentOutputs().reduce(function(accum, output) {
+    return accum + output.value
+  }, 0)
+}
 
-  this.processPendingTx = function(tx){
-    processTx(tx, true)
+Wallet.prototype.getChangeAddress = function() {
+  if (this.changeAddresses.length === 0) {
+    this.generateChangeAddress()
   }
 
-  this.processConfirmedTx = function(tx){
-    processTx(tx, false)
-  }
+  return this.changeAddresses[this.changeAddresses.length - 1]
+}
 
-  function processTx(tx, isPending) {
-    var txid = tx.getId()
+Wallet.prototype.getInternalPrivateKey = function(index) {
+  return this.getInternalAccount().derive(index).privKey
+}
 
-    tx.outs.forEach(function(txOut, i) {
-      var address
+Wallet.prototype.getPrivateKey = function(index) {
+  return this.getExternalAccount().derive(index).privKey
+}
 
-      try {
-        address = Address.fromOutputScript(txOut.script, network).toString()
-      } catch(e) {
-        if (!(e.message.match(/has no matching Address/))) throw e
+Wallet.prototype.getPrivateKeyForAddress = function(address) {
+  if (includeAddress(this.addresses, address)) {
+    var index = this.addresses.indexOf(address)
+
+    return this.getPrivateKey(index)
   }
 
-      if (isMyAddress(address)) {
-        var output = txid + ':' + i
+  if (includeAddress(this.changeAddresses, address)) {
+    var index = this.changeAddresses.indexOf(address)
 
-        me.outputs[output] = {
-          from: output,
-          value: txOut.value,
-          address: address,
-          pending: isPending
-        }
+    return this.getInternalPrivateKey(index)
   }
-    })
 
-    tx.ins.forEach(function(txIn, i) {
-      // copy and convert to big-endian hex
-      var txinId = new Buffer(txIn.hash)
-      Array.prototype.reverse.call(txinId)
-      txinId = txinId.toString('hex')
+  assert(false, 'Unknown address. Make sure the address is from the keychain and has been generated')
+}
 
-      var output = txinId + ':' + txIn.index
+Wallet.prototype.getReceiveAddress = function() {
+  if (this.addresses.length === 0) {
+    this.generateAddress()
+  }
+
+  return this.addresses[this.addresses.length - 1]
+}
 
-      if (!(output in me.outputs)) return
+Wallet.prototype.getUnspentOutputs = function() {
+  var utxo = []
 
-      if (isPending) {
-        me.outputs[output].to = txid + ':' + i
-        me.outputs[output].pending = true
-      } else {
-        delete me.outputs[output]
-      }
-    })
+  for(var key in this.outputs){
+    var output = this.outputs[key]
+    if(!output.to) utxo.push(outputToUnspentOutput(output))
   }
 
-  this.createTx = function(to, value, fixedFee, changeAddress) {
-    assert(value > network.dustThreshold, value + ' must be above dust threshold (' + network.dustThreshold + ' Satoshis)')
+  return utxo
+}
 
-    var utxos = getCandidateOutputs(value)
-    var accum = 0
-    var subTotal = value
-    var addresses = []
+Wallet.prototype.setUnspentOutputs = function(utxo) {
+  console.warn('setUnspentOutputs is deprecated, please use the constructor option instead')
 
-    var tx = new Transaction()
-    tx.addOutput(to, value)
+  this.outputs = processUnspentOutputs(utxo)
+}
 
-    for (var i = 0; i < utxos.length; ++i) {
-      var utxo = utxos[i]
-      addresses.push(utxo.address)
+Wallet.prototype.signWith = function(tx, addresses) {
+  assert.equal(tx.ins.length, addresses.length, 'Number of addresses must match number of transaction inputs')
 
-      var outpoint = utxo.from.split(':')
-      tx.addInput(outpoint[0], parseInt(outpoint[1]))
+  addresses.forEach(function(address, i) {
+    var key = this.getPrivateKeyForAddress(address)
 
-      var fee = fixedFee == undefined ? estimateFeePadChangeOutput(tx) : fixedFee
+    tx.sign(i, key)
+  }, this)
 
-      accum += utxo.value
-      subTotal = value + fee
-      if (accum >= subTotal) {
-        var change = accum - subTotal
+  return tx
+}
 
-        if (change > network.dustThreshold) {
-          tx.addOutput(changeAddress || getChangeAddress(), change)
-        }
+function outputToUnspentOutput(output){
+  var hashAndIndex = output.from.split(":")
 
-        break
-      }
+  return {
+    hash: hashAndIndex[0],
+    index: parseInt(hashAndIndex[1]),
+    address: output.address,
+    value: output.value,
+    pending: output.pending
   }
+}
 
-    assert(accum >= subTotal, 'Not enough funds (incl. fee): ' + accum + ' < ' + subTotal)
+function estimatePaddedFee(tx, network) {
+  var tmpTx = tx.clone()
+  tmpTx.addOutput(Script.EMPTY, network.dustSoftThreshold || 0)
 
-    this.signWith(tx, addresses)
-    return tx
+  return network.estimateFee(tmpTx)
+}
+
+function processUnspentOutputs(utxos) {
+  var outputs = {}
+
+  utxos.forEach(function(utxo){
+    var hash = new Buffer(utxo.hash, 'hex')
+    var index = utxo.index
+    var address = utxo.address
+    var value = utxo.value
+
+    // FIXME: remove alternative in 2.x.y
+    if (index === undefined) index = utxo.outputIndex
+
+    assert.equal(hash.length, 32, 'Expected hash length of 32, got ' + hash.length)
+    assert.equal(typeof index, 'number', 'Expected number index, got ' + index)
+    assert.doesNotThrow(function() { Address.fromBase58Check(address) }, 'Expected Base58 Address, got ' + address)
+    assert.equal(typeof value, 'number', 'Expected number value, got ' + value)
+
+    var key = utxo.hash + ':' + utxo.index
+
+    outputs[key] = {
+      from: key,
+      address: address,
+      value: value,
+      pending: utxo.pending
     }
+  })
+
+  return outputs
+}
 
-  function getCandidateOutputs() {
+function getCandidateOutputs(outputs/*, value*/) {
   var unspent = []
 
-    for (var key in me.outputs) {
-      var output = me.outputs[key]
+  for (var key in outputs) {
+    var output = outputs[key]
     if (!output.pending) unspent.push(output)
   }
 
@@ -238,67 +251,54 @@ function Wallet(seed, network) {
   })
 
   return sortByValueDesc
-  }
+}
 
-  function estimateFeePadChangeOutput(tx) {
-    var tmpTx = tx.clone()
-    tmpTx.addOutput(getChangeAddress(), network.dustSoftThreshold || 0)
+function processTx(tx, isPending) {
+  var txid = tx.getId()
 
-    return network.estimateFee(tmpTx)
-  }
+  tx.outs.forEach(function(txOut, i) {
+    var address
 
-  function getChangeAddress() {
-    if(me.changeAddresses.length === 0) me.generateChangeAddress();
-    return me.changeAddresses[me.changeAddresses.length - 1]
+    try {
+      address = Address.fromOutputScript(txOut.script, this.network).toString()
+    } catch(e) {
+      if (!(e.message.match(/has no matching Address/))) throw e
     }
 
-  this.signWith = function(tx, addresses) {
-    assert.equal(tx.ins.length, addresses.length, 'Number of addresses must match number of transaction inputs')
-
-    addresses.forEach(function(address, i) {
-      var key = me.getPrivateKeyForAddress(address)
-
-      tx.sign(i, key)
-    })
+    var myAddresses = this.addresses.concat(this.changeAddresses)
+    if (includeAddress(myAddresses, address)) {
+      var output = txid + ':' + i
 
-    return tx
+      this.outputs[output] = {
+        from: output,
+        value: txOut.value,
+        address: address,
+        pending: isPending
       }
-
-  this.getMasterKey = function() { return masterkey }
-  this.getAccountZero = function() { return accountZero }
-  this.getInternalAccount = function() { return internalAccount }
-  this.getExternalAccount = function() { return externalAccount }
-
-  this.getPrivateKey = function(index) {
-    return externalAccount.derive(index).privKey
     }
+  }, this)
 
-  this.getInternalPrivateKey = function(index) {
-    return internalAccount.derive(index).privKey
-  }
+  tx.ins.forEach(function(txIn, i) {
+    // copy and convert to big-endian hex
+    var txinId = new Buffer(txIn.hash)
+    Array.prototype.reverse.call(txinId)
+    txinId = txinId.toString('hex')
 
-  this.getPrivateKeyForAddress = function(address) {
-    var index
-    if((index = this.addresses.indexOf(address)) > -1) {
-      return this.getPrivateKey(index)
-    } else if((index = this.changeAddresses.indexOf(address)) > -1) {
-      return this.getInternalPrivateKey(index)
-    } else {
-      throw new Error('Unknown address. Make sure the address is from the keychain and has been generated.')
-    }
-  }
+    var output = txinId + ':' + txIn.index
 
-  function isReceiveAddress(address){
-    return me.addresses.indexOf(address) > -1
-  }
+    if (!(output in this.outputs)) return
 
-  function isChangeAddress(address){
-    return me.changeAddresses.indexOf(address) > -1
+    if (isPending) {
+      this.outputs[output].to = txid + ':' + i
+      this.outputs[output].pending = true
+    } else {
+      delete this.outputs[output]
     }
+  }, this)
+}
 
-  function isMyAddress(address) {
-    return isReceiveAddress(address) || isChangeAddress(address)
-  }
+function includeAddress(addresses, address) {
+  return addresses.indexOf(address) > -1
 }
 
 module.exports = Wallet

test/wallet.js

@@ -26,13 +26,17 @@ function fakeTxId(i) {
 }
 
 describe('Wallet', function() {
-  var seed, wallet
+  var seed
   beforeEach(function(){
     seed = crypto.sha256("don't use a string seed like this in real life")
-    wallet = new Wallet(seed)
   })
 
   describe('constructor', function() {
+    var wallet
+    beforeEach(function(){
+      wallet = new Wallet(seed)
+    })
+
     it('defaults to Bitcoin network', function() {
       assert.equal(wallet.getMasterKey().network, networks.bitcoin)
     })
@@ -116,6 +120,11 @@ describe('Wallet', function() {
   })
 
   describe('generateChangeAddress', function(){
+    var wallet
+    beforeEach(function(){
+      wallet = new Wallet(seed)
+    })
+
     it('generates change addresses', function(){
       var wallet = new Wallet(seed, networks.testnet)
       var expectedAddresses = ["mnXiDR4MKsFxcKJEZjx4353oXvo55iuptn"]
@@ -126,6 +135,11 @@ describe('Wallet', function() {
   })
 
   describe('getPrivateKey', function(){
+    var wallet
+    beforeEach(function(){
+      wallet = new Wallet(seed)
+    })
+
     it('returns the private key at the given index of external account', function(){
       var wallet = new Wallet(seed, networks.testnet)
 
@@ -135,6 +149,11 @@ describe('Wallet', function() {
   })
 
   describe('getInternalPrivateKey', function(){
+    var wallet
+    beforeEach(function(){
+      wallet = new Wallet(seed)
+    })
+
     it('returns the private key at the given index of internal account', function(){
       var wallet = new Wallet(seed, networks.testnet)
 
@@ -144,6 +163,11 @@ describe('Wallet', function() {
   })
 
   describe('getPrivateKeyForAddress', function(){
+    var wallet
+    beforeEach(function(){
+      wallet = new Wallet(seed)
+    })
+
     it('returns the private key for the given address', function(){
       var wallet = new Wallet(seed, networks.testnet)
       wallet.generateChangeAddress()
@@ -162,58 +186,63 @@ describe('Wallet', function() {
 
     it('raises an error when address is not found', function(){
       var wallet = new Wallet(seed, networks.testnet)
+
       assert.throws(function() {
         wallet.getPrivateKeyForAddress("n2fiWrHqD6GM5GiEqkbWAc6aaZQp3ba93X")
-      }, /Unknown address. Make sure the address is from the keychain and has been generated./)
+      }, /Unknown address. Make sure the address is from the keychain and has been generated/)
     })
   })
 
   describe('Unspent Outputs', function(){
-    var expectedUtxo, expectedOutputKey
+    var utxo, expectedOutputKey
+    var wallet
+
     beforeEach(function(){
-      expectedUtxo = {
-        "hash":"6a4062273ac4f9ea4ffca52d9fd102b08f6c32faa0a4d1318e3a7b2e437bb9c7",
-        "outputIndex": 0,
+      utxo = {
         "address" : "1AZpKpcfCzKDUeTFBQUL4MokQai3m3HMXv",
-        "value": 20000,
-        "pending": true
+        "hash": fakeTxId(6),
+        "index": 0,
+        "pending": true,
+        "value": 20000
       }
-      expectedOutputKey = expectedUtxo.hash + ":" + expectedUtxo.outputIndex
+
+      expectedOutputKey = utxo.hash + ":" + utxo.index
     })
 
-    function addUtxoToOutput(utxo){
-      var key = utxo.hash + ":" + utxo.outputIndex
-      wallet.outputs[key] = {
-        from: key,
-        address: utxo.address,
-        value: utxo.value,
-        pending: utxo.pending
-      }
-    }
+    describe('on construction', function(){
+      beforeEach(function(){
+        wallet = new Wallet(seed, networks.bitcoin, [utxo])
+      })
 
-    describe('getBalance', function(){
-      var utxo1
+      it('matches the expected behaviour', function(){
+        var output = wallet.outputs[expectedOutputKey]
+
+        assert(output)
+        assert.equal(output.value, utxo.value)
+        assert.equal(output.address, utxo.address)
+      })
+    })
 
+    describe('getBalance', function(){
       beforeEach(function(){
-        utxo1 = cloneObject(expectedUtxo)
-        utxo1.hash = utxo1.hash.replace('7', 'l')
+        var utxo1 = cloneObject(utxo)
+        utxo1.hash = fakeTxId(5)
+
+        wallet = new Wallet(seed, networks.bitcoin, [utxo, utxo1])
       })
 
       it('sums over utxo values', function(){
-        addUtxoToOutput(expectedUtxo)
-        addUtxoToOutput(utxo1)
-
         assert.equal(wallet.getBalance(), 40000)
       })
     })
 
     describe('getUnspentOutputs', function(){
       beforeEach(function(){
-        addUtxoToOutput(expectedUtxo)
+        wallet = new Wallet(seed, networks.bitcoin, [utxo])
       })
 
       it('parses wallet outputs to the expect format', function(){
-        assert.deepEqual(wallet.getUnspentOutputs(), [expectedUtxo])
+        assert.deepEqual(wallet.getUnspentOutputs(), [utxo])
       })
 
       it("ignores pending spending outputs (outputs with 'to' property)", function(){
@@ -223,40 +252,54 @@ describe('Wallet', function() {
         assert.deepEqual(wallet.getUnspentOutputs(), [])
       })
     })
+  })
 
+  // FIXME: remove in 2.x.y
   describe('setUnspentOutputs', function(){
     var utxo
+    var expectedOutputKey
+
     beforeEach(function(){
-        utxo = cloneObject([expectedUtxo])
+      utxo = {
+        hash: fakeTxId(0),
+        index: 0,
+        address: '115qa7iPZqn6as57hxLL8E9VUnhmGQxKWi',
+        value: 500000
+      }
+
+      expectedOutputKey = utxo.hash + ":" + utxo.index
+
+      wallet = new Wallet(seed, networks.bitcoin)
     })
 
     it('matches the expected behaviour', function(){
-        wallet.setUnspentOutputs(utxo)
-        verifyOutputs()
+      wallet.setUnspentOutputs([utxo])
+
+      var output = wallet.outputs[expectedOutputKey]
+      assert(output)
+      assert.equal(output.value, utxo.value)
+      assert.equal(output.address, utxo.address)
     })
 
     describe('required fields', function(){
-        ['outputIndex', 'address', 'hash', 'value'].forEach(function(field){
+      ['index', 'address', 'hash', 'value'].forEach(function(field){
         it("throws an error when " + field + " is missing", function(){
-            delete utxo[0][field]
+          delete utxo[field]
 
           assert.throws(function() {
-              wallet.setUnspentOutputs(utxo)
-            }, new RegExp('Invalid unspent output: key ' + field + ' is missing'))
+            wallet.setUnspentOutputs([utxo])
           })
         })
       })
-
-      function verifyOutputs() {
-        var output = wallet.outputs[expectedOutputKey]
-        assert(output)
-        assert.equal(output.value, utxo[0].value)
-        assert.equal(output.address, utxo[0].address)
-      }
     })
   })
 
   describe('Process transaction', function(){
+    var wallet
+    beforeEach(function(){
+      wallet = new Wallet(seed)
+    })
+
     var addresses
     var tx
 
@@ -389,39 +432,42 @@ describe('Wallet', function() {
   })
 
   describe('createTx', function(){
-    var to, value
+    var wallet
     var address1, address2
+    var to, value
 
     beforeEach(function(){
-      to = '15mMHKL96tWAUtqF3tbVf99Z8arcmnJrr3'
+      to = 'mt7MyTVVEWnbwpF5hBn6fgnJcv95Syk2ue'
       value = 500000
 
-      // generate 2 addresses
-      address1 = wallet.generateAddress()
-      address2 = wallet.generateAddress()
+      address1 = "n1GyUANZand9Kw6hGSV9837cCC9FFUQzQa"
+      address2 = "n2fiWrHqD6GM5GiEqkbWAc6aaZQp3ba93X"
 
-      // set up 3 utxo
-      utxo = [
+      // set up 3 utxos
+      var utxos = [
         {
           "hash": fakeTxId(1),
-          "outputIndex": 0,
-          "address" : address1,
+          "index": 0,
+          "address": address1,
           "value": 400000 // not enough for value
         },
         {
           "hash": fakeTxId(2),
-          "outputIndex": 1,
-          "address" : address1,
+          "index": 1,
+          "address": address1,
           "value": 500000 // enough for only value
         },
         {
           "hash": fakeTxId(3),
-          "outputIndex": 0,
+          "index": 0,
           "address" : address2,
           "value": 510000 // enough for value and fee
         }
       ]
-      wallet.setUnspentOutputs(utxo)
+
+      wallet = new Wallet(seed, networks.testnet, utxos)
+      wallet.generateAddress()
+      wallet.generateAddress()
     })
 
     describe('transaction fee', function(){
@@ -441,17 +487,18 @@ describe('Wallet', function() {
       })
 
       it('does not overestimate fees when network has dustSoftThreshold', function(){
-        var wallet = new Wallet(seed, networks.litecoin)
-        var address = wallet.generateAddress()
-        wallet.setUnspentOutputs([{
+        var utxo = {
           hash: fakeTxId(0),
-          outputIndex: 0,
-          address: address,
+          index: 0,
+          address: "LeyySKbQrRRwodKEj1W4a8y3YQupPLw5os",
           value: 500000
-        }])
+        }
+
+        var wallet = new Wallet(seed, networks.litecoin, [utxo])
+        wallet.generateAddress()
 
         value = 200000
-        var tx = wallet.createTx(address, value)
+        var tx = wallet.createTx(utxo.address, value)
 
         assert.equal(getFee(wallet, tx), 100000)
       })
@@ -477,66 +524,38 @@ describe('Wallet', function() {
         assert.equal(tx.ins[0].index, 0)
       })
 
-      it('ignores pending outputs', function(){
-        utxo.push(
-          {
-            "hash": fakeTxId(4),
-            "outputIndex": 0,
-            "address" : address2,
-            "value": 530000,
-            "pending": true
-          }
-        )
-        wallet.setUnspentOutputs(utxo)
+      it('uses confirmed outputs', function(){
+        var tx2 = new Transaction()
+        tx2.addInput(fakeTxId(4), 0)
+        tx2.addOutput(address2, 530000)
 
+        wallet.processConfirmedTx(tx2)
         var tx = wallet.createTx(to, value)
 
         assert.equal(tx.ins.length, 1)
-        assert.deepEqual(tx.ins[0].hash, fakeTxHash(3))
+        assert.deepEqual(tx.ins[0].hash, tx2.getHash())
         assert.equal(tx.ins[0].index, 0)
       })
-    })
 
-    describe('works for testnet', function(){
-      it('should create transaction', function(){
-        var wallet = new Wallet(seed, networks.testnet)
-        var address = wallet.generateAddress()
-
-        wallet.setUnspentOutputs([{
-          hash: fakeTxId(0),
-          outputIndex: 0,
-          address: address,
-          value: value
-        }])
-
-        var to = 'mt7MyTVVEWnbwpF5hBn6fgnJcv95Syk2ue'
-        var toValue = value - 10000
+      it('ignores pending outputs', function(){
+        var tx2 = new Transaction()
+        tx2.addInput(fakeTxId(4), 0)
+        tx2.addOutput(address2, 530000)
 
-        var tx = wallet.createTx(to, toValue)
-        assert.equal(tx.outs.length, 1)
+        wallet.processPendingTx(tx2)
+        var tx = wallet.createTx(to, value)
 
-        var outAddress = Address.fromOutputScript(tx.outs[0].script, networks.testnet)
-        assert.equal(outAddress.toString(), to)
-        assert.equal(tx.outs[0].value, toValue)
+        assert.equal(tx.ins.length, 1)
+        assert.deepEqual(tx.ins[0].hash, fakeTxHash(3))
+        assert.equal(tx.ins[0].index, 0)
       })
     })
 
     describe('changeAddress', function(){
       it('should allow custom changeAddress', function(){
-        var wallet = new Wallet(seed, networks.testnet)
-        var address = wallet.generateAddress()
-
-        wallet.setUnspentOutputs([{
-          hash: fakeTxId(0),
-          outputIndex: 0,
-          address: address,
-          value: value
-        }])
-        assert.equal(wallet.getBalance(), value)
-
         var changeAddress = 'mfrFjnKZUvTcvdAK2fUX5D8v1Epu5H8JCk'
-        var to = 'mt7MyTVVEWnbwpF5hBn6fgnJcv95Syk2ue'
-        var toValue = value / 2
+        var fromValue = 510000
+        var toValue = fromValue / 2
         var fee = 1e3
 
         var tx = wallet.createTx(to, toValue, fee, changeAddress)
@@ -549,7 +568,7 @@ describe('Wallet', function() {
         assert.equal(tx.outs[0].value, toValue)
 
         assert.equal(outAddress1.toString(), changeAddress)
-        assert.equal(tx.outs[1].value, value - (toValue + fee))
+        assert.equal(tx.outs[1].value, fromValue - (toValue + fee))
       })
     })
 
@@ -559,7 +578,7 @@ describe('Wallet', function() {
 
         assert.equal(tx.outs.length, 1)
         var out = tx.outs[0]
-        var outAddress = Address.fromOutputScript(out.script)
+        var outAddress = Address.fromOutputScript(out.script, networks.testnet)
 
         assert.equal(outAddress.toString(), to)
         assert.equal(out.value, value)
@@ -574,7 +593,7 @@ describe('Wallet', function() {
 
           assert.equal(tx.outs.length, 2)
           var out = tx.outs[1]
-          var outAddress = Address.fromOutputScript(out.script)
+          var outAddress = Address.fromOutputScript(out.script, networks.testnet)
 
           assert.equal(outAddress.toString(), wallet.changeAddresses[1])
           assert.equal(out.value, 10000)
@@ -588,7 +607,7 @@ describe('Wallet', function() {
 
           assert.equal(wallet.changeAddresses.length, 1)
           var out = tx.outs[1]
-          var outAddress = Address.fromOutputScript(out.script)
+          var outAddress = Address.fromOutputScript(out.script, networks.testnet)
 
           assert.equal(outAddress.toString(), wallet.changeAddresses[0])
           assert.equal(out.value, 10000)