Merge pull request #89 from Dcousens/eckeyfnc

Adds ECPubKey.verify and tests for ECKey signing

src/eckey.js

@@ -110,6 +110,14 @@ ECKey.prototype.multiply = function(key) {
     return ECKey(this.priv.multiply(ECKey(key).priv),this.compressed)
 }
 
+ECKey.prototype.sign = function(hash) {
+  return ecdsa.sign(hash, this.priv);
+}
+
+ECKey.prototype.verify = function(hash, sig) {
+  return this.getPub().verify(hash, sig)
+}
+
 var ECPubKey = function(input, compressed) {
     if (!(this instanceof ECPubKey)) { return new ECPubKey(input, compressed); }
     if (!input) {
@@ -178,18 +186,11 @@ ECPubKey.prototype.getAddress = function(version) {
     return new Address(util.sha256ripe160(this.toBytes()), version);
 }
 
-ECKey.prototype.sign = function (hash) {
-  return ecdsa.sign(hash, this.priv);
-};
-
-ECKey.prototype.verify = function (hash, sig) {
-  return ecdsa.verify(hash, sig, this.getPub()['export']('bytes'));
-};
+ECPubKey.prototype.verify = function(hash, sig) {
+  return ecdsa.verify(hash, sig, this.toBytes())
+}
 
-/**
- * Parse an exported private key contained in a string.
- */
 module.exports = {
   ECKey: ECKey,
   ECPubKey: ECPubKey
-};
+}

test/eckey.js

@@ -138,4 +138,34 @@ describe('ECKey', function() {
             }
         })
     });
+
+    describe('signing', function() {
+      var hpriv = 'ca48ec9783cf3ad0dfeff1fc254395a2e403cbbc666477b61b45e31d3b8ab458'
+      var hcpub = '024b12d9d7c77db68388b6ff7c89046174c871546436806bcd80d07c28ea811992'
+      var message = 'Vires in numeris'
+
+      it('should verify against the private key', function() {
+        var priv = new ECKey(hpriv)
+        var signature = priv.sign(message)
+
+        assert(priv.verify(message, signature))
+      })
+
+      it('should verify against the public key', function() {
+        var priv = new ECKey(hpriv)
+        var pub = new ECPubKey(hcpub, true)
+        var signature = priv.sign(message)
+
+        assert(pub.verify(message, signature))
+      })
+
+      it('should not verify against the wrong private key', function() {
+        var priv1 = new ECKey(hpriv)
+        var priv2 = new ECKey('1111111111111111111111111111111111111111111111111111111111111111')
+
+        var signature = priv1.sign(message)
+
+        assert(!priv2.verify(message, signature))
+      })
+    })
 })