Browse Source

Get sourcecodeVersion and sourcecodeDate only when .git is available

It might not be when installing btc-rpc-explorer globally (npm install -g).

Without this, running btc-rpc-explorer without .git resulted in:

fatal: Not a git repository (or any parent up to mount point /home/user)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Unhandled Rejection at: Promise Promise {
  <rejected> TypeError: Cannot read property 'all' of null
    at btc-rpc-explorer/app.js:334:35
fix-133-memory-crash
Nadav Ivgi 6 years ago
parent
commit
246b2baeef
  1. 3
      app.js
  2. 1
      views/layout.pug

3
app.js

@ -329,8 +329,9 @@ app.runOnStartup = function() {
});
}
if (global.sourcecodeVersion == null) {
if (global.sourcecodeVersion == null && fs.existsSync('.git')) {
simpleGit(".").log(["-n 1"], function(err, log) {
if (err) { return console.error('error accessing git repo:', err); }
global.sourcecodeVersion = log.all[0].hash.substring(0, 10);
global.sourcecodeDate = log.all[0].date.substring(0, "0000-00-00".length);
});

1
views/layout.pug

@ -124,6 +124,7 @@ html(lang="en")
dd
a(href="https://github.com/janoside/btc-rpc-explorer") github.com/janoside/btc-rpc-explorer
if (sourcecodeVersion)
dt Running Version
dd
a(href=("https://github.com/janoside/btc-rpc-explorer/commit/" + sourcecodeVersion)) #{sourcecodeVersion}

Loading…
Cancel
Save