Browse Source

make extra_warning_flags return an Option

wintest
gnzlbg 7 years ago
parent
commit
75c8d46d8d
  1. 11
      src/lib.rs

11
src/lib.rs

@ -227,10 +227,10 @@ impl ToolFamily {
} }
/// What the flags to enable extra warnings /// What the flags to enable extra warnings
fn extra_warnings_flags(&self) -> &'static str { fn extra_warnings_flags(&self) -> Option<&'static str> {
match *self { match *self {
ToolFamily::Msvc => "", ToolFamily::Msvc => None,
ToolFamily::Gnu | ToolFamily::Clang => "-Wextra", ToolFamily::Gnu | ToolFamily::Clang => Some("-Wextra"),
} }
} }
@ -1268,8 +1268,9 @@ impl Build {
} }
if self.extra_warnings { if self.extra_warnings {
let wflags = cmd.family.extra_warnings_flags().into(); if let Some(wflags) = cmd.family.extra_warnings_flags() {
cmd.push_cc_arg(wflags); cmd.push_cc_arg(wflags.into());
}
} }
for flag in self.flags.iter() { for flag in self.flags.iter() {

Loading…
Cancel
Save