update bip32 derivations, using xpriv and xpub serialization format

lib/bitcoin.py

@@ -577,20 +577,22 @@ def CKD_pub(cK, c, n):
     return cK_n, c_n
 
 
-def parse_xprv(xprv):
+
-    xprv = DecodeBase58Check( xprv )
+def deserialize_xkey(xkey):
-    assert len(xprv) == 78
+    xkey = DecodeBase58Check(xkey) 
-    assert xprv[0:4] == "0488ADE4".decode('hex')
+    assert len(xkey) == 78
-    depth = ord(xprv[4])
+    assert xkey[0:4].encode('hex') in ["0488ADE4", "0488B21E"]
-    fingerprint = xprv[5:9]
+    assert sequence.startswith(branch)
-    child_number = xprv[9:13]
+    depth = ord(xkey[4])
-    c = xprv[13:13+32]
+    fingerprint = xkey[5:9]
-    k = xprv[13+33:]
+    child_number = xkey[9:13]
-    K, cK = get_pubkeys_from_secret(k)
+    c = xkey[13:13+32]
-    key_id = hash_160(cK)
+    if xkey[0:4].encode('hex') == "0488ADE4":
-    print "keyid", key_id.encode('hex')
+        K_or_k = xkey[13+33:]
-    print "address", hash_160_to_bc_address(key_id)
+    else:
-    print "secret key", SecretToASecret(k, True)
+        K_or_k = xkey[13+32:]
+    return depth, fingerprint, child_number, c, K_or_k
+
 
 
 def bip32_root(seed):
@@ -607,15 +609,8 @@ def bip32_root(seed):
 
 
 def bip32_private_derivation(xprv, branch, sequence):
-    xprv = DecodeBase58Check( xprv ) 
+    depth, fingerprint, child_number, c, k = deserialize_xkey(xprv)
-    assert len(xprv) == 78
-    assert xprv[0:4] == "0488ADE4".decode('hex')
     assert sequence.startswith(branch)
-    depth = ord(xprv[4])
-    fingerprint = xprv[5:9]
-    child_number = xprv[9:13]
-    c = xprv[13:13+32]
-    k = xprv[13+33:]
     sequence = sequence[len(branch):]
     for n in sequence.split('/'):
         if n == '': continue
@@ -635,15 +630,8 @@ def bip32_private_derivation(xprv, branch, sequence):
 
 
 def bip32_public_derivation(xpub, branch, sequence):
-    xpub = DecodeBase58Check( xpub ) 
+    depth, fingerprint, child_number, c, cK = deserialize_xkey(xpub)
-    assert len(xpub) == 78
-    assert xpub[0:4] == "0488B21E".decode('hex')
     assert sequence.startswith(branch)
-    depth = ord(xpub[4])
-    fingerprint = xpub[5:9]
-    child_number = xpub[9:13]
-    c = xpub[13:13+32]
-    cK = xpub[13+32:]
     sequence = sequence[len(branch):]
     for n in sequence.split('/'):
         if n == '': continue
@@ -683,7 +671,6 @@ def test_bip32(seed, sequence):
     xprv, xpub = bip32_root(seed)
     print xpub
     print xprv
-    #parse_xprv(xprv)
 
     assert sequence[0:2] == "m/"
     path = 'm'