Some people complained that due to merging the two word lists,
it is difficult to restore from a metal backup, as they planned
to rely on the "4 letter prefixes are unique in bip39 word list" property.
So we colour words that are only in old list.
previously load_transactions() had to be called before upgrade();
now we reverse this order.
to reproduce/illustrate issue, before this commit:
try running convert_version_17 and convert_version_18
(e.g. see testcase test_upgrade_from_client_2_9_3_old_seeded_with_realistic_history)
and then in qt console:
>> wallet.storage.db.get_data_ref('spent_outpoints') == wallet.storage.db.spent_outpoints
False
>> wallet.storage.db.get_data_ref('verified_tx3') == wallet.storage.db.verified_tx
False
We already delete unused Qt modules, but we weren't deleting their PyQt5 modules.
-----
taken from Electron-Cash/Electron-Cash@e044c94677160b6e6bb1a981b22a4b85103de6cb
Importing from PyQt5.Qt is an unnecessary fallback that loads every PyQt5 module.
-----
taken from Electron-Cash/Electron-Cash@d69471b31d1f25a703588f48ee0cc5afdf1f1f2f
pkg2appimage excludes libusb-1.0.so by default for no good reason:
83483c2971/excludelist (L112)
This can cause an issue when the AppImage loads the systems libusb but the
systems libusb in turn loads libudev from the AppImage. The kernel ABI for
libusb will not be changing so it is safe to bundle it into the AppImage.
-----
taken from Electron-Cash/Electron-Cash@25d45fdcbfa335d83de876ff16e978a058d17e22
Specifically GoBack and UserCancelled will not be suppressed anymore.
Previously, if 'run_next' raised GoBack, that would propagate out fully,
while if 'func' itself raised it would be suppressed. This was confusing.
somewhat related: #5334
SomberNight
ThomasV
Jochen Hoenicke
shyrwall
JeremyRand
Axel Gembe