style fixes

libsolidity/ExpressionCompiler.cpp

@@ -1035,7 +1035,7 @@ void ExpressionCompiler::appendHighBitsCleanup(IntegerType const& _typeOnStack)
 void ExpressionCompiler::appendExternalFunctionCall(
 	FunctionType const& _functionType,
 	vector<ASTPointer<Expression const>> const& _arguments
-	)
+)
 {
 	solAssert(_functionType.takesArbitraryParameters() ||
 			  _arguments.size() == _functionType.getParameterTypes().size(), "");
@@ -1106,7 +1106,7 @@ void ExpressionCompiler::appendExternalFunctionCall(
 
 	//Propagate error condition (if CALL pushes 0 on stack).
 	auto tag = m_context.appendConditionalJump();
-	m_context << eth::Instruction::STOP << tag;	// STOP if CALL leaves 0.//	}
+	m_context << eth::Instruction::STOP << tag;	// STOP if CALL leaves 0.
 
 	if (_functionType.valueSet())
 		m_context << eth::Instruction::POP;

test/libsolidity/SolidityEndToEndTest.cpp

@@ -4145,7 +4145,7 @@ BOOST_AUTO_TEST_CASE(evm_exceptions_in_constructor_call_fail)
 			uint public test = 1;
 			function testIt()
 			{
-				A a;
+				A a = new A();
 				++test;
 			}
 		}

test/libsolidity/solidityExecutionFramework.h

@@ -47,7 +47,6 @@ public:
                 m_compiler.reset(false, m_addStandardSources);
                 m_compiler.addSource("", _sourceCode);
                 ETH_TEST_REQUIRE_NO_THROW(m_compiler.compile(m_optimize), "Compiling contract failed");
-
                 bytes code = m_compiler.getBytecode(_contractName);
                 sendMessage(code, true, _value);
                 return m_output;
@@ -80,16 +79,15 @@ public:
                 bytes solidityResult = callContractFunction(_sig, _arguments...);
                 bytes cppResult = callCppAndEncodeResult(_cppFunction, _arguments...);
                 BOOST_CHECK_MESSAGE(
-            solidityResult == cppResult, "Computed values do not match.\nSolidity: " + toHex(solidityResult) + "\nC++:      " + toHex(cppResult));
+                        solidityResult == cppResult,
+                        "Computed values do not match.\nSolidity: " +
+                                toHex(solidityResult) +
+                                "\nC++:      " +
+                                toHex(cppResult));
         }
 
         template <class CppFunction, class... Args>
-    void testSolidityAgainstCppOnRange(
-        std::string _sig,
-        CppFunction const& _cppFunction,
-        u256 const& _rangeStart,
-        u256 const& _rangeEnd
-    )
+        void testSolidityAgainstCppOnRange(std::string _sig, CppFunction const& _cppFunction, u256 const& _rangeStart, u256 const& _rangeEnd)
         {
                 for (u256 argument = _rangeStart; argument < _rangeEnd; ++argument)
                 {
@@ -150,10 +148,10 @@ protected:
         {
                 m_state.addBalance(m_sender, _value); // just in case
                 eth::Executive executive(m_state, eth::LastHashes(), 0);
-        eth::Transaction t = _isCreation ? eth::Transaction(
-            _value, m_gasPrice, m_gas, _data, 0, KeyPair::create().sec()
-        ) : eth::Transaction(_value, m_gasPrice, m_gas, m_contractAddress, _data, 0, KeyPair::create().sec());
-
+                eth::Transaction t =
+                        _isCreation ?
+                        eth::Transaction(_value, m_gasPrice, m_gas, _data, 0, KeyPair::create().sec()) :
+                        eth::Transaction(_value, m_gasPrice, m_gas, m_contractAddress, _data, 0, KeyPair::create().sec());
                 bytes transactionRLP = t.rlp();
                 try
                 {