Browse Source

Fix EventEmitter memory leak (#415)

fix-progress-browserify
Sindre Sorhus 7 years ago
committed by GitHub
parent
commit
98a714462c
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
  1. 10
      index.js

10
index.js

@ -206,7 +206,7 @@ function requestAsEventEmitter(opts) {
} }
}); });
cacheReq.on('request', req => { cacheReq.once('request', req => {
req.once('error', err => { req.once('error', err => {
clearInterval(progressInterval); clearInterval(progressInterval);
@ -220,7 +220,7 @@ function requestAsEventEmitter(opts) {
ee.emit('error', new got.RequestError(err, opts)); ee.emit('error', new got.RequestError(err, opts));
}); });
ee.on('request', req => { ee.once('request', req => {
ee.emit('uploadProgress', { ee.emit('uploadProgress', {
percent: 0, percent: 0,
transferred: 0, transferred: 0,
@ -347,10 +347,10 @@ function asPromise(opts) {
}); });
}); });
ee.on('error', reject); ee.once('error', reject);
ee.on('redirect', proxy.emit.bind(proxy, 'redirect'));
ee.on('uploadProgress', proxy.emit.bind(proxy, 'uploadProgress')); ee.on('uploadProgress', proxy.emit.bind(proxy, 'uploadProgress'));
ee.on('downloadProgress', proxy.emit.bind(proxy, 'downloadProgress')); ee.on('downloadProgress', proxy.emit.bind(proxy, 'downloadProgress'));
ee.on('redirect', proxy.emit.bind(proxy, 'redirect'));
}); });
const promise = timeoutFn(cancelable); const promise = timeoutFn(cancelable);
@ -427,8 +427,8 @@ function asStream(opts) {
proxy.emit('response', res); proxy.emit('response', res);
}); });
ee.on('redirect', proxy.emit.bind(proxy, 'redirect'));
ee.on('error', proxy.emit.bind(proxy, 'error')); ee.on('error', proxy.emit.bind(proxy, 'error'));
ee.on('redirect', proxy.emit.bind(proxy, 'redirect'));
ee.on('uploadProgress', proxy.emit.bind(proxy, 'uploadProgress')); ee.on('uploadProgress', proxy.emit.bind(proxy, 'uploadProgress'));
ee.on('downloadProgress', proxy.emit.bind(proxy, 'downloadProgress')); ee.on('downloadProgress', proxy.emit.bind(proxy, 'downloadProgress'));

Loading…
Cancel
Save