Browse Source

Remove todo in favour of warning for awareness

Better log a warning, the assumption is that we rarely see this. Let's see if that is true.
refactor/no-log-handler
Daniel Karzel 3 years ago
parent
commit
7355c339a6
No known key found for this signature in database GPG Key ID: 30C3FC2E438ADB6E
  1. 8
      daemon/src/maker_cfd.rs

8
daemon/src/maker_cfd.rs

@ -502,7 +502,13 @@ impl Actor {
command: TakerCommand::NotifyInvalidOrderId { id: order_id },
})
.await?;
// TODO: Return an error here?
// An outdated order on the taker side does not require any state change on the
// maker. notifying the taker with a specific message should be sufficient.
// Since this is a scenario that we should rarely see we log
// a warning to be sure we don't trigger this code path frequently.
tracing::warn!("Taker tried to take order with outdated id {}", order_id);
return Ok(());
}
};

Loading…
Cancel
Save