Merge pull request #602 from gre/unify-constants

unify all constants

src/api/Ledger.js

@@ -1,7 +1,6 @@
 // @flow
 import type { Currency } from '@ledgerhq/live-common/lib/types'
-
+import { LEDGER_REST_API_BASE } from 'config/constants'
-const BASE_URL = process.env.LEDGER_REST_API_BASE || 'https://api.ledgerwallet.com/'
 
 export const blockchainBaseURL = ({ ledgerExplorerId }: Currency): ?string =>
-  ledgerExplorerId ? `${BASE_URL}blockchain/v2/${ledgerExplorerId}` : null
+  ledgerExplorerId ? `${LEDGER_REST_API_BASE}blockchain/v2/${ledgerExplorerId}` : null

src/components/CalculateBalance.js

@@ -79,7 +79,12 @@ const mapStateToProps = (state: State, props: OwnProps) => {
   }
 }
 
+const hash = ({ balanceHistory, balanceEnd }) => `${balanceHistory.length}_${balanceEnd}`
+
 class CalculateBalance extends Component<Props> {
+  shouldComponentUpdate(nextProps) {
+    return hash(nextProps) !== hash(this.props)
+  }
   render() {
     const { children } = this.props
     return children(this.props)

src/config/constants.js

@@ -1,10 +1,18 @@
 // @flow
 
-const intFromEnv = (key: string, def: number) => {
+const intFromEnv = (key: string, def: number): number => {
   const v = process.env[key]
   if (!isNaN(v)) return parseInt(v, 10)
   return def
 }
+const boolFromEnv = (key: string): boolean => {
+  const v = process.env[key]
+  return (v && v !== '0' && v !== 'false') || false
+}
+
+const stringFromEnv = (key: string, def: string): string => process.env[key] || def
+
+// time and delays...
 
 export const GET_CALLS_TIMEOUT = intFromEnv('GET_CALLS_TIMEOUT', 30 * 1000)
 export const GET_CALLS_RETRY = intFromEnv('GET_CALLS_RETRY', 2)
@@ -19,6 +27,41 @@ export const CHECK_UPDATE_DELAY = 5e3
 
 export const DEVICE_DISCONNECT_DEBOUNCE = intFromEnv('LEDGER_DEVICE_DISCONNECT_DEBOUNCE', 500)
 
+// Endpoints...
+
+export const LEDGER_REST_API_BASE = stringFromEnv(
+  'LEDGER_REST_API_BASE',
+  'https://api.ledgerwallet.com/',
+)
+export const MANAGER_API_BASE = stringFromEnv(
+  'MANAGER_API_BASE',
+  'https://beta.manager.live.ledger.fr/api',
+)
+export const BASE_SOCKET_URL = stringFromEnv('BASE_SOCKET_URL', 'ws://api.ledgerwallet.com/update')
+export const BASE_SOCKET_URL_SECURE = stringFromEnv(
+  'BASE_SOCKET_URL',
+  'wss://api.ledgerwallet.com/update',
+)
+
+// Flags
+
+export const DEBUG_DEVICE = boolFromEnv('DEBUG_DEVICE')
+export const DEBUG_NETWORK = boolFromEnv('DEBUG_NETWORK')
+export const DEBUG_COMMANDS = boolFromEnv('DEBUG_COMMANDS')
+export const DEBUG_DB = boolFromEnv('DEBUG_DB')
+export const DEBUG_ACTION = boolFromEnv('DEBUG_ACTION')
+export const DEBUG_TAB_KEY = boolFromEnv('DEBUG_TAB_KEY')
+export const DEBUG_LIBCORE = boolFromEnv('DEBUG_LIBCORE')
+export const DEBUG_WS = boolFromEnv('DEBUG_WS')
+export const LEDGER_RESET_ALL = boolFromEnv('LEDGER_RESET_ALL')
+export const LEDGER_DEBUG_ALL_LANGS = boolFromEnv('LEDGER_DEBUG_ALL_LANGS')
+export const SKIP_GENUINE = boolFromEnv('SKIP_GENUINE')
+export const SKIP_ONBOARDING = boolFromEnv('SKIP_ONBOARDING')
+export const SHOW_LEGACY_NEW_ACCOUNT = boolFromEnv('SHOW_LEGACY_NEW_ACCOUNT')
+export const HIGHLIGHT_I18N = boolFromEnv('HIGHLIGHT_I18N')
+
+// Other constants
+
 export const MODAL_ADD_ACCOUNTS = 'MODAL_ADD_ACCOUNTS'
 export const MODAL_OPERATION_DETAILS = 'MODAL_OPERATION_DETAILS'
 export const MODAL_RECEIVE = 'MODAL_RECEIVE'

src/config/languages.js

@@ -1,6 +1,7 @@
 // @flow
+import { LEDGER_DEBUG_ALL_LANGS } from 'config/constants'
 
 const allLanguages = ['en', 'fr']
 const prodStableLanguages = ['en']
-const languages = process.env.LEDGER_DEBUG_ALL_LANGS ? allLanguages : prodStableLanguages
+const languages = LEDGER_DEBUG_ALL_LANGS ? allLanguages : prodStableLanguages
 export default languages

src/helpers/apps/listApps.js

@@ -1,12 +1,12 @@
 // @flow
 import axios from 'axios'
 
-import { API_BASE_URL } from 'helpers/constants'
+import { MANAGER_API_BASE } from 'config/constants'
 
 export default async (targetId: string | number) => {
   try {
     const { data: deviceData } = await axios.get(
-      `${API_BASE_URL}/device_versions_target_id/${targetId}`,
+      `${MANAGER_API_BASE}/device_versions_target_id/${targetId}`,
     )
     const { data } = await axios.get('https://api.ledgerwallet.com/update/applications')
 

src/helpers/common.js

@@ -4,9 +4,15 @@
 
 import qs from 'qs'
 import type Transport from '@ledgerhq/hw-transport'
+import { BASE_SOCKET_URL, BASE_SOCKET_URL_SECURE } from 'config/constants'
 import { createDeviceSocket } from './socket'
 
-import { BASE_SOCKET_URL, APDUS, MANAGER_API_URL } from './constants'
+const APDUS = {
+  GET_FIRMWARE: [0xe0, 0x01, 0x00, 0x00],
+  // we dont have common call that works inside app & dashboard
+  // TODO: this should disappear.
+  GET_FIRMWARE_FALLBACK: [0xe0, 0xc4, 0x00, 0x00],
+}
 
 export type LedgerScriptParams = {
   firmware?: string,
@@ -35,7 +41,9 @@ export async function createSocketDialog(
   managerUrl: boolean = false,
 ): Promise<string> {
   console.warn('DEPRECATED createSocketDialog: use createDeviceSocket') // eslint-disable-line
-  const url = `${managerUrl ? MANAGER_API_URL : BASE_SOCKET_URL}${endpoint}?${qs.stringify(params)}`
+  const url = `${managerUrl ? BASE_SOCKET_URL_SECURE : BASE_SOCKET_URL}${endpoint}?${qs.stringify(
+    params,
+  )}`
   return createDeviceSocket(transport, url).toPromise()
 }
 

src/helpers/constants.js

@@ -1,13 +0,0 @@
-// Socket endpoint
-
-export const BASE_SOCKET_URL = 'ws://api.ledgerwallet.com/update'
-export const MANAGER_API_URL = 'wss://api.ledgerwallet.com/update'
-export const API_BASE_URL = process.env.API_BASE_URL || 'https://beta.manager.live.ledger.fr/api'
-
-// List of APDUS
-export const APDUS = {
-  GET_FIRMWARE: [0xe0, 0x01, 0x00, 0x00],
-  // we dont have common call that works inside app & dashboard
-  // TODO: this should disappear.
-  GET_FIRMWARE_FALLBACK: [0xe0, 0xc4, 0x00, 0x00],
-}

src/helpers/deviceAccess.js

@@ -2,6 +2,7 @@
 import createSemaphore from 'semaphore'
 import type Transport from '@ledgerhq/hw-transport'
 import TransportNodeHid from '@ledgerhq/hw-transport-node-hid'
+import { DEBUG_DEVICE } from 'config/constants'
 import { retry } from './promise'
 
 // all open to device must use openDevice so we can prevent race conditions
@@ -20,7 +21,7 @@ export const withDevice: WithDevice = devicePath => {
     takeSemaphorePromise(sem, async () => {
       const t = await retry(() => TransportNodeHid.open(devicePath), { maxRetry: 1 })
 
-      if (process.env.DEBUG_DEVICE > 0) t.setDebugMode(true)
+      if (DEBUG_DEVICE) t.setDebugMode(true)
       try {
         const res = await job(t)
         // $FlowFixMe

src/helpers/devices/getFirmwareInfo.js

@@ -2,7 +2,7 @@
 import axios from 'axios'
 import isEmpty from 'lodash/isEmpty'
 
-import { API_BASE_URL } from 'helpers/constants'
+import { MANAGER_API_BASE } from 'config/constants'
 
 type Input = {
   version: string,
@@ -12,10 +12,13 @@ type Input = {
 let error
 export default async (data: Input) => {
   try {
-    const { data: seFirmwareVersion } = await axios.post(`${API_BASE_URL}/firmware_versions_name`, {
+    const { data: seFirmwareVersion } = await axios.post(
+      `${MANAGER_API_BASE}/firmware_versions_name`,
+      {
         se_firmware_name: data.version,
         target_id: data.targetId,
-    })
+      },
+    )
 
     if (!isEmpty(seFirmwareVersion)) {
       return seFirmwareVersion

src/helpers/devices/getIsGenuine.js

@@ -1,11 +1,12 @@
 // @flow
 import type Transport from '@ledgerhq/hw-transport'
 import { createSocketDialog } from 'helpers/common'
+import { SKIP_GENUINE } from 'config/constants'
 
 export default async (
   transport: Transport<*>,
   { targetId }: { targetId: string | number },
 ): Promise<string> =>
-  process.env.SKIP_GENUINE > 0
+  SKIP_GENUINE
     ? new Promise(resolve => setTimeout(() => resolve('0000'), 1000))
     : createSocketDialog(transport, '/genuine', { targetId }, true)

src/helpers/devices/getLatestFirmwareForDevice.js

@@ -1,7 +1,7 @@
 // @flow
 import axios from 'axios'
 import isEmpty from 'lodash/isEmpty'
-import { API_BASE_URL } from 'helpers/constants'
+import { MANAGER_API_BASE } from 'config/constants'
 
 import getFirmwareInfo from './getFirmwareInfo'
 
@@ -17,11 +17,11 @@ export default async (data: Input) => {
 
     // Get device infos from targetId
     const { data: deviceVersion } = await axios.get(
-      `${API_BASE_URL}/device_versions_target_id/${data.targetId}`,
+      `${MANAGER_API_BASE}/device_versions_target_id/${data.targetId}`,
     )
 
     // Fetch next possible firmware
-    const { data: serverData } = await axios.post(`${API_BASE_URL}/get_latest_firmware`, {
+    const { data: serverData } = await axios.post(`${MANAGER_API_BASE}/get_latest_firmware`, {
       current_se_firmware_version: seFirmwareVersion.id,
       device_version: deviceVersion.id,
       providers: [1],

src/helpers/libcore.js

@@ -4,6 +4,7 @@ import logger from 'logger'
 import Btc from '@ledgerhq/hw-app-btc'
 import { withDevice } from 'helpers/deviceAccess'
 import { getCryptoCurrencyById } from '@ledgerhq/live-common/lib/helpers/currencies'
+import { SHOW_LEGACY_NEW_ACCOUNT } from 'config/constants'
 
 import type { AccountRaw, OperationRaw, OperationType } from '@ledgerhq/live-common/lib/types'
 import type { NJSAccount, NJSOperation } from '@ledgerhq/ledger-core/src/ledgercore_doc'
@@ -28,8 +29,6 @@ type Props = {
   onAccountScanned: AccountRaw => void,
 }
 
-const { SHOW_LEGACY_NEW_ACCOUNT } = process.env
-
 export function scanAccountsOnDevice(props: Props): Promise<AccountRaw[]> {
   const { devicePath, currencyId, onAccountScanned, core } = props
   const currency = getCryptoCurrencyById(currencyId)

src/internals/index.js

@@ -4,6 +4,7 @@ import logger from 'logger'
 import uuid from 'uuid/v4'
 import { setImplementation } from 'api/network'
 import sentry from 'sentry/node'
+import { DEBUG_NETWORK } from 'config/constants'
 
 require('../env')
 
@@ -15,7 +16,7 @@ let sentryEnabled = process.env.INITIAL_SENTRY_ENABLED || false
 
 sentry(() => sentryEnabled, process.env.SENTRY_USER_ID)
 
-if (process.env.DEBUG_NETWORK) {
+if (DEBUG_NETWORK) {
   setImplementation(networkArg => {
     const id = uuid()
     return new Promise((resolve, reject) => {

src/logger.js

@@ -9,6 +9,15 @@
  * - for analytics in the future
  */
 
+import {
+  DEBUG_COMMANDS,
+  DEBUG_DB,
+  DEBUG_ACTION,
+  DEBUG_TAB_KEY,
+  DEBUG_LIBCORE,
+  DEBUG_WS,
+} from 'config/constants'
+
 const logs = []
 
 const MAX_LOG_LENGTH = 500
@@ -47,12 +56,12 @@ const makeSerializableLog = (o: mixed) => {
   return String(o)
 }
 
-const logCmds = !__DEV__ || process.env.DEBUG_COMMANDS
+const logCmds = !__DEV__ || DEBUG_COMMANDS
-const logDb = !__DEV__ || process.env.DEBUG_DB
+const logDb = !__DEV__ || DEBUG_DB
-const logRedux = !__DEV__ || process.env.DEBUG_ACTION
+const logRedux = !__DEV__ || DEBUG_ACTION
-const logTabkey = !__DEV__ || process.env.DEBUG_TAB_KEY
+const logTabkey = !__DEV__ || DEBUG_TAB_KEY
-const logLibcore = !__DEV__ || process.env.DEBUG_LIBCORE
+const logLibcore = !__DEV__ || DEBUG_LIBCORE
-const logWS = !__DEV__ || process.env.DEBUG_WS
+const logWS = !__DEV__ || DEBUG_WS
 
 export default {
   onCmd: (type: string, id: string, spentTime: number, data?: any) => {

src/reducers/onboarding.js

@@ -1,5 +1,6 @@
 // @flow
 
+import { SKIP_ONBOARDING } from 'config/constants'
 import { handleActions, createAction } from 'redux-actions'
 
 type Step = {
@@ -29,7 +30,7 @@ export type OnboardingState = {
 
 const state: OnboardingState = {
   stepIndex: 0,
-  stepName: process.env.SKIP_ONBOARDING ? 'finish' : 'start',
+  stepName: SKIP_ONBOARDING ? 'finish' : 'start',
   genuine: {
     pinStepPass: false,
     recoveryStepPass: false,

src/renderer/i18n/instanciate.js

@@ -1,3 +1,4 @@
+import { HIGHLIGHT_I18N } from 'config/constants'
 import i18n from 'i18next'
 
 const commonConfig = {
@@ -29,7 +30,7 @@ export function createWithBackend(backend, backendOpts) {
     ...backendOpts,
   }
 
-  if (process.env.HIGHLIGHT_I18N) {
+  if (HIGHLIGHT_I18N) {
     config.postProcess = 'highlight'
   }
 

src/renderer/init.js

@@ -11,6 +11,7 @@ import moment from 'moment'
 import createStore from 'renderer/createStore'
 import events from 'renderer/events'
 
+import { LEDGER_RESET_ALL } from 'config/constants'
 import { enableGlobalTab, disableGlobalTab, isGlobalTabEnabled } from 'config/global-tab'
 
 import { fetchAccounts } from 'actions/accounts'
@@ -34,7 +35,7 @@ const rootNode = document.getElementById('app')
 const TAB_KEY = 9
 
 async function init() {
-  if (process.env.LEDGER_RESET_ALL) {
+  if (LEDGER_RESET_ALL) {
     await hardReset()
   }