Browse Source

tests: log funder_faileds as unusual not broken

test_funding_cancel_race explicitly attempts to trigger this via a race
condition; this conflicts with our post-test checks that no broken
logs were logged. as a middle ground, we log it as unusual, not broken,
as it's possible for it to attempt to fail if it was begun at the same
time as the complete is.
pull/2938/head
lisa neigut 6 years ago
committed by neil saitug
parent
commit
4638995037
  1. 2
      lightningd/opening_control.c

2
lightningd/opening_control.c

@ -1005,7 +1005,7 @@ static unsigned int openingd_msg(struct subd *openingd,
return 0; return 0;
case WIRE_OPENING_FUNDER_FAILED: case WIRE_OPENING_FUNDER_FAILED:
if (!uc->fc) { if (!uc->fc) {
log_broken(openingd->log, "Unexpected FUNDER_FAILED %s", log_unusual(openingd->log, "Unexpected FUNDER_FAILED %s",
tal_hex(tmpctx, msg)); tal_hex(tmpctx, msg));
tal_free(openingd); tal_free(openingd);
return 0; return 0;

Loading…
Cancel
Save