update libwally to latest version 0.6.9

Also removes a workaround caused by bug in libwally (!95) which has
been fixed.

Signed-off-by: Lawrence Nahum <lawrence@greenaddress.it>

channeld/test/run-full_channel.c

@@ -345,8 +345,7 @@ int main(void)
 	const struct chainparams *chainparams = chainparams_for_network("bitcoin");
 
 	wally_init(0);
-	/* FIXME: https://github.com/ElementsProject/libwally-core/issues/95 */
+	secp256k1_ctx = wally_get_secp_context();
-	secp256k1_ctx = (secp256k1_context *)wally_get_secp_context();
 	setup_tmpctx();
 
 	feerate_per_kw = tal_arr(tmpctx, u32, NUM_SIDES);

common/daemon.c

@@ -149,8 +149,7 @@ void daemon_setup(const char *argv0,
 	/* We handle write returning errors! */
 	signal(SIGPIPE, SIG_IGN);
 	wally_init(0);
-	/* FIXME: https://github.com/ElementsProject/libwally-core/issues/95 */
+	secp256k1_ctx = wally_get_secp_context();
-	secp256k1_ctx = (secp256k1_context *)wally_get_secp_context();
 
 	setup_tmpctx();
 	io_poll_override(daemon_poll);

common/test/run-bolt11.c

@@ -130,8 +130,7 @@ int main(void)
 	const char *badstr;
 
 	wally_init(0);
-	/* FIXME: https://github.com/ElementsProject/libwally-core/issues/95 */
+	secp256k1_ctx = wally_get_secp_context();
-	secp256k1_ctx = (secp256k1_context *)wally_get_secp_context();
 	setup_tmpctx();
 
 	/* BOLT #11:

common/test/run-derive_basepoints.c

@@ -55,8 +55,7 @@ int main(void)
 	struct info *baseline, *info;
 
 	wally_init(0);
-	/* FIXME: https://github.com/ElementsProject/libwally-core/issues/95 */
+	secp256k1_ctx = wally_get_secp_context();
-	secp256k1_ctx = (secp256k1_context *)wally_get_secp_context();
 	baseline = new_info(ctx);
 	assert(derive_basepoints(&baseline->seed, &baseline->funding_pubkey,
 				 &baseline->basepoints,

common/test/run-features.c

@@ -15,8 +15,7 @@ int main(void)
 
 	setup_locale();
 	wally_init(0);
-	/* FIXME: https://github.com/ElementsProject/libwally-core/issues/95 */
+	secp256k1_ctx = wally_get_secp_context();
-	secp256k1_ctx = (secp256k1_context *)wally_get_secp_context();
 	setup_tmpctx();
 
 	bits = tal_arr(tmpctx, u8, 0);

external/libwally-core

@@ -1 +1 @@
-Subproject commit f27740564955e9a63d2946bdb0099622c0977b6e
+Subproject commit 1b7ce30c8ceb9e95820486dbc1015b04f5f8b683

wallet/test/run-wallet.c

@@ -1187,8 +1187,7 @@ int main(void)
 
 	setup_tmpctx();
 	wally_init(0);
-	/* FIXME: https://github.com/ElementsProject/libwally-core/issues/95 */
+	secp256k1_ctx = wally_get_secp_context();
-	secp256k1_ctx = (secp256k1_context *)wally_get_secp_context();
 	ld = tal(tmpctx, struct lightningd);
 	ld->config = test_config;