lukechilds/lightning - lightning - Gitea: Git with a cup of tea

Author	SHA1	Message	Date
Rusty Russell	50f5eb34b4	openingd: take peer before we're opening, wait for explicit funding msg. Prior to this, lightningd would hand uninteresting peers back to connectd, which would then return it to lightningd if it sent a non-gossip msg, or if lightningd asked it to release the peer. Now connectd hands the peer to lightningd once we've done the init handshake, which hands it off to openingd. This is a deep structural change, so we do the minimum here and cleanup in the following patches. Lightningd: 1. Remove peer_nongossip handling from connect_control and peer_control. 2. Remove list of outstanding fundchannel command; it was only needed to find the race between us asking connectd to release the peer and it reconnecting. 3. We can no longer tell if the remote end has started trying to fund a channel (until it has succeeded): it's very transitory anyway so not worth fixing. 4. We now always have a struct peer, and allocate an uncommitted_channel for it, though it may never be used if neither end funds a channel. 5. We start funding on messages for openingd: we can get a funder_reply or a fundee, or an error in response to our request to fund a channel. so we handle all of them. 6. A new peer_start_openingd() is called after connectd hands us a peer. 7. json_fund_channel just looks through local peers; there are none hidden in connectd any more. 8. We sometimes start a new openingd just to send an error message. Openingd: 1. We always have information we need to accept them funding a channel (in the init message). 2. We have to listen for three fds: peer, gossip and master, so we opencode the poll. 3. We have an explicit message to start trying to fund a channel. 4. We can be told to send a message in our init message. Testing: 1. We don't handle some things gracefully yet, so two tests are disabled. 2. 'hand_back_peer .*: now local again' from connectd is no longer a message, openingd says 'Handed peer, entering loop' once its managing it. 3. peer['state'] used to be set to 'GOSSIPING' (otherwise this field doesn't exist; 'state' is now per-channel. It doesn't exist at all now. 4. Some tests now need to turn on IO logging in openingd, not connectd. 5. There's a gap between connecting on one node and having connectd on the peer hand over the connection to openingd. Our tests sometimes checked getpeers() on the peer, and didn't see anything, so line_graph needed updating. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>	7 years ago
Christian Decker	19092a8f1b	pytest: Migrate close and onchain tests to test_closing.py	7 years ago
Rusty Russell	965c20caae	tests: reenable developer tests. `72d103d6bb` deprecated DEVELOPER env var in favor of config.vars, but didn't update test_closing.py or test_gossip.py. `5d0a54b7f0` then removed the explicit DEVELOPER= setting from Travis. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>	7 years ago
Christian Decker	fac1d24ce3	pytest: Use the port from the lightning node Signed-off-by: Christian Decker <decker.christian@gmail.com>	7 years ago
Christian Decker	104645ba3a	pytest: Fix flaky `test_closing_id` test It simply wasn't waiting for us to register the peer before attempting to open a connection. Moved into a separate test to be able rerun multiple times. Signed-off-by: Christian Decker <decker.christian@gmail.com>	7 years ago

1 2 3