The current code enumerates the partitions and uses the index of this enumeration to query partition parameters rather than the actual partition number that is reported and expected by partx. This might not work in certain cases.
Example:
/dev/sda1
/dev/sda2
/dev/sda5
The partition number of the last partition is 5 but current code will use 3. This PR fixes this so that the actual number reported by partx is used for all operations rather than the enumerated index.
ChangeLog: Fix error when partitions numbers are not sequential
Signed-off-by: Purushotham Nayak <purunaya@cisco.com>
Currently this is redirecting stdout to stderr and then writing the
now blank stdout to the log file. This results in log messages getting
displayed to the screen but missed in the log file.
Changelog: Title
Signed-off-by: Drew Moseley <drew.moseley@northern.tech>
This also requires us to use noninteractive install environment
because of new timezone selection in tzdata package.
Changelog: Fix 404 download errors when trying to run `docker-build`.
Signed-off-by: Kristian Amlie <kristian.amlie@northern.tech>
Since `set -o nounset` is now enabled for the whole file, the environment
variables need to be set to empty string if not present to preserve the old behaviour.
Changelog: None
Signed-off-by: Ole Petter <ole.orhagen@northern.tech>
This was a regression introduced as a merge error on my behalf. This was already
moved out of the `mender-convert` script by Dell Green, and into
`modules/git.sh` which handles the version parsing in the
`docker-mender-convert` script.
Changelog: None
Signed-off-by: Ole Petter <ole.orhagen@northern.tech>
This information is not used when loading via UEFI, instead it is
queried directly from the UEFI provider.
Changelog: Commit
Signed-off-by: Kristian Amlie <kristian.amlie@northern.tech>
From grub-mender-grubenv changelog:
Changelog: add 'rootwait' to bootargs
Changelog: grubenv: Handle debug command prompt when running as EFI app.
Changelog: utilize regexp to dynamically set mender_grub_storage_device
Signed-off-by: Kristian Amlie <kristian.amlie@northern.tech>
This change required some changes to the current test scripts. Most notably, the
whole conversion is now run two times. One for the compressed input image, and
one for the already decompressed image.
Also, the test framework was cleaned up significantly, and the number of
arguments passed to the 'convert_and_test' function has been decreased to remove
the redundancies that were present (like passing the image name, and the image
name with the extension, in two separate parameters).
These changes are a result of the changes introduced with:
* MEN-3052: https://tracker.mender.io/browse/MEN-3052
Changelog: None
Signed-off-by: Ole Petter <ole.orhagen@northern.tech>
Previously the user would have to manually decompress an input image prior to
handing it over to mender-convert. With this change, files compressed in the
formats: lzma, gzip, or zip archives will be automatically decompressed,
converted, and then recompressed.
Note that the zip archive can only contain one image file, otherwise the
conversion will fail. Thus if the archive contains multiple files, human
interaction is required. This simply involves unzipping the archive yourself,
and then pass in the image, just like in the old workflow.
Ticket: https://tracker.mender.io/browse/MEN-3052
Changelog: Added automatic decompression of input images, so that the convert
tool now accepts compressed input images in the formats: lzma, gzip, and zip.
The images will also be recompressed to the input format automatically.
Signed-off-by: Ole Petter <ole.orhagen@northern.tech>
Changelog: Title
Add generic x86 configuration which can be applied on any distribution
runing on x86.
As example is added setup for converting CentOS Linux 8 (test device was used Intel NUC)
with 128G SSD.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
This may not be correct in all use cases but for the files that are currently created,
they should be owned by root. At a minimum they should not have the UID of the user
invoking mender-convert.
Changelog: Title
Signed-off-by: Drew Moseley <drew.moseley@northern.tech>
This adds more accurate descriptions of what error actually occured during
script execution, as compared to previously, where it would silently fail, and
it could be hard to figure out exactly where the error occured.
Now, upon an error, the script will always output these lines (or similar) at the end:
```bash
2020-04-23 18:53:34 [ERROR] [mender-convert] mender-convert failed
2020-04-23 18:53:34 [DEBUG] [mender-convert-extract] When running: (./mender-convert-extract:109): run_and_log_cmd():
dd if=/dev/zer of=work/boot-generated.vfat count=40 bs=1M status=none
dd: failed to open '/dev/zer': No such file or directory
2020-04-23 18:53:34 [ERROR] [mender-convert] mender-convert exit code: 1
```
Which is a description of which part of the program failed. What the exit code
was, and the last command entry in the debug log, and if any, the collected
output from the command is printed.
Changelog: Print improved error diagnostics before exiting on an error
Signed-off-by: Ole Petter <ole.orhagen@northern.tech>
Purushotham Nayak
Mirza Krak
Dell Green
Kristian Amlie
Drew Moseley
Kristian Amlie
oleorhagen
Marek Belisko