Browse Source

Checking instanceof PixelArray

v1.x
Tj Holowaychuk 14 years ago
parent
commit
09023539c4
  1. 3
      lib/context2d.js
  2. 2
      src/CanvasGradient.cc
  3. 8
      src/ImageData.cc

3
lib/context2d.js

@ -483,6 +483,5 @@ Context2d.prototype.createImageData = function(width, height){
height = width.height; height = width.height;
width = width.width; width = width.width;
} }
var arr = new PixelArray(width, height); return new ImageData(new PixelArray(width, height));
return new ImageData(arr);
}; };

2
src/CanvasGradient.cc

@ -36,8 +36,6 @@ Handle<Value>
Gradient::New(const Arguments &args) { Gradient::New(const Arguments &args) {
HandleScope scope; HandleScope scope;
// TODO: separate concerns / validate args
// Linear // Linear
if (4 == args.Length()) { if (4 == args.Length()) {
Gradient *grad = new Gradient( Gradient *grad = new Gradient(

8
src/ImageData.cc

@ -36,8 +36,12 @@ ImageData::Initialize(Handle<Object> target) {
Handle<Value> Handle<Value>
ImageData::New(const Arguments &args) { ImageData::New(const Arguments &args) {
HandleScope scope; HandleScope scope;
// TODO: arg assertions Local<Object> obj = args[0]->ToObject();
PixelArray *arr = ObjectWrap::Unwrap<PixelArray>(args[0]->ToObject());
if (!PixelArray::constructor->HasInstance(obj))
return ThrowException(Exception::TypeError(String::New("CanvasPixelArray expected")));
PixelArray *arr = ObjectWrap::Unwrap<PixelArray>(obj);
ImageData *imageData = new ImageData(arr); ImageData *imageData = new ImageData(arr);
args.This()->Set(String::NewSymbol("data"), args[0]); args.This()->Set(String::NewSymbol("data"), args[0]);
imageData->Wrap(args.This()); imageData->Wrap(args.This());

Loading…
Cancel
Save