Browse Source

Merge branch 'memleaks'

v1.x
King Koopa 11 years ago
parent
commit
922cd79673
  1. 2
      binding.gyp
  2. 2
      package.json
  3. 8
      src/Canvas.cc
  4. 12
      src/JPEGStream.h

2
binding.gyp

@ -21,7 +21,7 @@
'targets': [ 'targets': [
{ {
'target_name': 'canvas', 'target_name': 'canvas',
'include_dirs': ["<!(node -p -e \"require('path').relative('.', require('path').dirname(require.resolve('nan')))\")"], 'include_dirs': ["<!(node -e \"require('nan')\")"],
'sources': [ 'sources': [
'src/Canvas.cc', 'src/Canvas.cc',
'src/CanvasGradient.cc', 'src/CanvasGradient.cc',

2
package.json

@ -9,7 +9,7 @@
"test": "make test" "test": "make test"
} }
, "dependencies": { , "dependencies": {
"nan": "~0.4.1" "nan": "~0.6.0"
} }
, "devDependencies": { , "devDependencies": {
"express": "3.0" "express": "3.0"

8
src/Canvas.cc

@ -211,7 +211,7 @@ Canvas::EIO_AfterToBuffer(eio_req *req) {
} else { } else {
Local<Object> buf = NanNewBufferHandle((char*)closure->data, closure->len); Local<Object> buf = NanNewBufferHandle((char*)closure->data, closure->len);
memcpy(Buffer::Data(buf), closure->data, closure->len); memcpy(Buffer::Data(buf), closure->data, closure->len);
Local<Value> argv[2] = { Local<Value>::New(Null()), buf }; Local<Value> argv[2] = { NanNewLocal<Value>(Null()), buf };
closure->pfn->Call(2, argv); closure->pfn->Call(2, argv);
} }
@ -348,7 +348,7 @@ streamPNG(void *c, const uint8_t *data, unsigned len) {
closure_t *closure = (closure_t *) c; closure_t *closure = (closure_t *) c;
Local<Object> buf = NanNewBufferHandle((char *)data, len); Local<Object> buf = NanNewBufferHandle((char *)data, len);
Local<Value> argv[3] = { Local<Value> argv[3] = {
Local<Value>::New(Null()) NanNewLocal<Value>(Null())
, buf , buf
, Integer::New(len) }; , Integer::New(len) };
MakeCallback(Context::GetCurrent()->Global(), closure->fn, 3, argv); MakeCallback(Context::GetCurrent()->Global(), closure->fn, 3, argv);
@ -423,8 +423,8 @@ NAN_METHOD(Canvas::StreamPNGSync) {
MakeCallback(Context::GetCurrent()->Global(), closure.fn, 1, argv); MakeCallback(Context::GetCurrent()->Global(), closure.fn, 1, argv);
} else { } else {
Local<Value> argv[3] = { Local<Value> argv[3] = {
Local<Value>::New(Null()) NanNewLocal<Value>(Null())
, Local<Value>::New(Null()) , NanNewLocal<Value>(Null())
, Integer::New(0) }; , Integer::New(0) };
MakeCallback(Context::GetCurrent()->Global(), closure.fn, 3, argv); MakeCallback(Context::GetCurrent()->Global(), closure.fn, 3, argv);
} }

12
src/JPEGStream.h

@ -34,8 +34,8 @@ empty_closure_output_buffer(j_compress_ptr cinfo){
closure_destination_mgr *dest = (closure_destination_mgr *) cinfo->dest; closure_destination_mgr *dest = (closure_destination_mgr *) cinfo->dest;
Local<Object> buf = NanNewBufferHandle((char *)dest->buffer, dest->bufsize); Local<Object> buf = NanNewBufferHandle((char *)dest->buffer, dest->bufsize);
Local<Value> argv[3] = { Local<Value> argv[3] = {
Local<Value>::New(Null()) NanNewLocal<Value>(Null())
, Local<Value>::New(buf) , NanNewLocal<Value>(buf)
, Integer::New(dest->bufsize) , Integer::New(dest->bufsize)
}; };
dest->closure->fn->Call(Context::GetCurrent()->Global(), 3, argv); dest->closure->fn->Call(Context::GetCurrent()->Global(), 3, argv);
@ -53,8 +53,8 @@ term_closure_destination(j_compress_ptr cinfo){
Local<Object> buf = NanNewBufferHandle((char *)dest->buffer, remaining); Local<Object> buf = NanNewBufferHandle((char *)dest->buffer, remaining);
Local<Value> data_argv[3] = { Local<Value> data_argv[3] = {
Local<Value>::New(Null()) NanNewLocal<Value>(Null())
, Local<Value>::New(buf) , NanNewLocal<Value>(buf)
, Integer::New(remaining) , Integer::New(remaining)
}; };
@ -62,8 +62,8 @@ term_closure_destination(j_compress_ptr cinfo){
// emit "end" // emit "end"
Local<Value> end_argv[3] = { Local<Value> end_argv[3] = {
Local<Value>::New(Null()) NanNewLocal<Value>(Null())
, Local<Value>::New(Null()) , NanNewLocal<Value>(Null())
, Integer::New(0) , Integer::New(0)
}; };

Loading…
Cancel
Save