Browse Source

Fixed deleteSync bug. Verified Node v0.8 compatibility.

ci/travis-osximage 0.1.2
JP Richardson 12 years ago
parent
commit
b1e6c3d044
  1. 5
      CHANGELOG.md
  2. 2
      Cakefile
  3. 2
      lib/index.js
  4. 2
      package.json
  5. 2
      src/index.coffee
  6. 16
      test/remove.test.coffee

5
CHANGELOG.md

@ -1,3 +1,8 @@
0.1.2 / 2012-06-15
==================
* Bug fix: `deleteSync()` didn't exist.
* Verified Node v0.8 compatibility.
0.1.1 / 2012-06-15 0.1.1 / 2012-06-15
================== ==================
* Fixed bug in `remove()`/`delete()` that wouldn't execute the function if a callback wasn't passed. * Fixed bug in `remove()`/`delete()` that wouldn't execute the function if a callback wasn't passed.

2
Cakefile

@ -15,7 +15,7 @@ task 'build', 'build lib/ from src/', ->
console.log "Error building. Code: #{code}" console.log "Error building. Code: #{code}"
task 'test', 'test project', (options) -> task 'test', 'test project', (options) ->
process.env['NODE_ENV'] = 'testing' process.env['NODE_ENV'] = 'test'
testutil.fetchTestFiles './test', (files) -> testutil.fetchTestFiles './test', (files) ->
files.unshift '--colors' files.unshift '--colors'
if options.grep? if options.grep?

2
lib/index.js

@ -29,7 +29,7 @@
fs["delete"] = fs.remove; fs["delete"] = fs.remove;
fs.deleteSync = fs.deleteSync; fs.deleteSync = fs.removeSync;
mkdir = require('./mkdir'); mkdir = require('./mkdir');

2
package.json

@ -1,6 +1,6 @@
{ {
"name" : "fs-extra", "name" : "fs-extra",
"version" : "0.1.1", "version" : "0.1.2",
"description" : "fs-extra contains methods that aren't included in the vanilla Node.js fs package.", "description" : "fs-extra contains methods that aren't included in the vanilla Node.js fs package.",
"homepage" : [ "homepage" : [
"https://github.com/jprichardson/node-fs-extra" "https://github.com/jprichardson/node-fs-extra"

2
src/index.coffee

@ -17,7 +17,7 @@ remove = require('./remove')
fs.remove = remove.remove fs.remove = remove.remove
fs.removeSync = remove.removeSync fs.removeSync = remove.removeSync
fs.delete = fs.remove fs.delete = fs.remove
fs.deleteSync = fs.deleteSync fs.deleteSync = fs.removeSync
mkdir = require('./mkdir') mkdir = require('./mkdir')
fs.mkdir = mkdir.mkdir fs.mkdir = mkdir.mkdir

16
test/remove.test.coffee

@ -39,9 +39,9 @@ describe 'fs-extra', ->
describe '+ removeSync()', -> describe '+ removeSync()', ->
it 'should delete directories and files synchronously', -> it 'should delete directories and files synchronously', ->
T path.existsSync(DIR) T fs.existsSync(DIR)
fs.removeSync(DIR) fs.removeSync(DIR)
F path.existsSync(DIR) F fs.existsSync(DIR)
it 'should delete an empty directory synchronously', -> it 'should delete an empty directory synchronously', ->
T fs.existsSync DIR T fs.existsSync DIR
@ -90,5 +90,17 @@ describe 'fs-extra', ->
fs.remove file fs.remove file
describe '+ delete()', ->
it 'should delete an empty directory', (done) ->
T fs.existsSync DIR
fs.delete DIR, (err) ->
T err is null
F fs.existsSync DIR
done()
describe '+ deleteSync()', ->
it 'should delete directories and files synchronously', ->
T fs.existsSync(DIR)
fs.deleteSync(DIR)
F fs.existsSync(DIR)

Loading…
Cancel
Save