|
|
|
|
<!--
|
|
|
|
|
Thank you for submitting a pull request to Node.js. Before you submit, please
|
|
|
|
|
review below requirements and walk through the checklist. You can 'tick'
|
|
|
|
|
a box by using the letter "x": [x].
|
|
|
|
|
|
|
|
|
|
Run the test suite by invoking: `make -j4 lint test` on linux or
|
|
|
|
|
`vcbuild test nosign` on Windows.
|
|
|
|
|
|
|
|
|
|
If this aims to fix a regression or you’re adding a feature, make sure you also
|
|
|
|
|
write a test. Finally – if possible – a benchmark that quantifies your changes.
|
|
|
|
|
|
|
|
|
|
Finally, read through our contributors guide and make adjustments as necessary:
|
|
|
|
|
https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
|
|
|
|
|
-->
|
|
|
|
|
|
|
|
|
|
##### Checklist
|
|
|
|
|
|
|
|
|
|
<!-- remove lines that do not apply to you -->
|
|
|
|
|
|
|
|
|
|
- [ ] tests and code linting passes
|
|
|
|
|
- [ ] a test and/or benchmark is included
|
|
|
|
|
- [ ] documentation is changed or added
|
|
|
|
|
- [ ] the commit message follows commit guidelines
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
##### Affected core subsystem(s)
|
|
|
|
|
|
|
|
|
|
<!-- provide affected core subsystem(s) (like doc, cluster, crypto, etc) -->
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
##### Description of change
|
|
|
|
|
|
|
|
|
|
<!-- provide a description of the change below this comment -->
|
