Browse Source

dns: fix ReferenceError in resolve() error path

A typo in the variable name makes it throw a ReferenceError instead of
the expected "Unknown type" error when dns.resolve() is passed a bad
record type argument.

Fixes the following exception:

  ReferenceError: type is not defined
    at Object.exports.resolve (dns.js:189:40)
    at /Users/bnoordhuis/src/master/test/simple/test-c-ares.js:48:9
    <snip>
v0.9.12-release
Xidorn Quan 12 years ago
committed by Ben Noordhuis
parent
commit
009ba02e18
  1. 2
      lib/dns.js
  2. 5
      test/simple/test-c-ares.js

2
lib/dns.js

@ -186,7 +186,7 @@ exports.resolve = function(domain, type_, callback_) {
if (typeof resolver === 'function') { if (typeof resolver === 'function') {
return resolver(domain, callback); return resolver(domain, callback);
} else { } else {
throw new Error('Unknown type "' + type + '"'); throw new Error('Unknown type "' + type_ + '"');
} }
}; };

5
test/simple/test-c-ares.js

@ -42,6 +42,11 @@ dns.lookup('::1', function(error, result, addressType) {
assert.equal(6, addressType); assert.equal(6, addressType);
}); });
// Try calling resolve with an unsupported type.
assert.throws(function() {
dns.resolve('www.google.com', 'HI');
}, /Unknown type/);
// Windows doesn't usually have an entry for localhost 127.0.0.1 in // Windows doesn't usually have an entry for localhost 127.0.0.1 in
// C:\Windows\System32\drivers\etc\hosts // C:\Windows\System32\drivers\etc\hosts
// so we disable this test on Windows. // so we disable this test on Windows.

Loading…
Cancel
Save