Browse Source

test: fix coverity UNINIT_CTOR cctest warning

Explicitly initialize `platform_` to nullptr.  Coverity cannot divine
it is set and cleared by the Setup() and TearDown() methods.

PR-URL: https://github.com/nodejs/node/pull/12387
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
v6.x
Ben Noordhuis 8 years ago
committed by Myles Borins
parent
commit
0383048b76
No known key found for this signature in database GPG Key ID: 933B01F40B5CA946
  1. 7
      test/cctest/node_test_fixture.h

7
test/cctest/node_test_fixture.h

@ -64,6 +64,10 @@ class NodeTestFixture : public ::testing::Test {
ArrayBufferAllocator allocator_; ArrayBufferAllocator allocator_;
v8::Isolate* isolate_; v8::Isolate* isolate_;
~NodeTestFixture() {
TearDown();
}
virtual void SetUp() { virtual void SetUp() {
platform_ = v8::platform::CreateDefaultPlatform(); platform_ = v8::platform::CreateDefaultPlatform();
v8::V8::InitializePlatform(platform_); v8::V8::InitializePlatform(platform_);
@ -73,13 +77,14 @@ class NodeTestFixture : public ::testing::Test {
} }
virtual void TearDown() { virtual void TearDown() {
if (platform_ == nullptr) return;
v8::V8::ShutdownPlatform(); v8::V8::ShutdownPlatform();
delete platform_; delete platform_;
platform_ = nullptr; platform_ = nullptr;
} }
private: private:
v8::Platform* platform_; v8::Platform* platform_ = nullptr;
}; };
#endif // TEST_CCTEST_NODE_TEST_FIXTURE_H_ #endif // TEST_CCTEST_NODE_TEST_FIXTURE_H_

Loading…
Cancel
Save