Browse Source

test: refactor test-fs-buffer

* Remove unneeded temp dir cleanup
* Add check for error in `.close()` callback
* Improve error reporting

On that last bullet point, the previous version of the test reported
errors like this:

```
AssertionError: [ '.empty-repl-history-file',
  '.node_repl_history',
  'GH-1899-output.js',
  'GH-892-request.js',
  'a.js',
  'a1.js',
  'agen deepStrictEqual [ '.empty-repl-history-file',
  '.node_repl_history',
  'GH-1899-output.js',
  'GH-892-request.js',
  'a.js',
  'a1.js',
  'agen
```

Now, they look like this:

```
AssertionError: expected *, got ! by hex decoding 2a
```

PR-URL: https://github.com/nodejs/node/pull/11232
Reviewed-By: James M Snell <jasnell@gmail.com>
v6
Rich Trott 8 years ago
parent
commit
05be62307d
  1. 20
      test/parallel/test-fs-buffer.js

20
test/parallel/test-fs-buffer.js

@ -18,8 +18,8 @@ assert.doesNotThrow(() => {
fs.open(buf, 'w+', common.mustCall((err, fd) => { fs.open(buf, 'w+', common.mustCall((err, fd) => {
assert.ifError(err); assert.ifError(err);
assert(fd); assert(fd);
fs.close(fd, common.mustCall(() => { fs.close(fd, common.mustCall((err) => {
fs.unlinkSync(buf); assert.ifError(err);
})); }));
})); }));
}); });
@ -29,13 +29,17 @@ assert.throws(() => {
}, /path must be a string or Buffer/); }, /path must be a string or Buffer/);
const dir = Buffer.from(common.fixturesDir); const dir = Buffer.from(common.fixturesDir);
fs.readdir(dir, 'hex', common.mustCall((err, list) => { fs.readdir(dir, 'hex', common.mustCall((err, hexList) => {
assert.ifError(err); assert.ifError(err);
list = list.map((i) => { fs.readdir(dir, common.mustCall((err, stringList) => {
return Buffer.from(i, 'hex').toString();
});
fs.readdir(dir, common.mustCall((err, list2) => {
assert.ifError(err); assert.ifError(err);
assert.deepStrictEqual(list, list2); stringList.forEach((val, idx) => {
const fromHexList = Buffer.from(hexList[idx], 'hex').toString();
assert.strictEqual(
fromHexList,
val,
`expected ${val}, got ${fromHexList} by hex decoding ${hexList[idx]}`
);
});
})); }));
})); }));

Loading…
Cancel
Save