mirror of https://github.com/lukechilds/node.git
Browse Source
This test setups two event listeners: one on a child process' exit event , another for the same child process' stdandard output's 'data' event. The data even listener writes to a stream, and the exit event listener ends it. Because the exit event can be emitted before the data event, there is a chance that something will be written to the stream after it's ended, and that an error is thrown. This change makes the test end the stream in the listener for the child process' standard output's end event, which is guaranteed to be emitted after the last data event, thus avoiding the race. PR: https://github.com/joyent/node/pull/9301 Reviewed-by: Bert Belder <bertbelder@gmail.com> Reviewed-by: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-by: Colin Ihrig <cjihrig@gmail.com>v1.8.0-commit
Julien Gilli
10 years ago
committed by
Bert Belder
1 changed files with 4 additions and 1 deletions
Loading…
Reference in new issue