mirror of https://github.com/lukechilds/node.git
Browse Source
Fixes: https://github.com/nodejs/node/issues/14386 Fixes: https://github.com/nodejs/node/issues/14381 PR-URL: https://github.com/nodejs/node/pull/14387 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>v6
committed by
Jeremiah Senkpiel
4 changed files with 65 additions and 1 deletions
@ -0,0 +1,32 @@ |
|||
'use strict'; |
|||
|
|||
const common = require('../common'); |
|||
const { OutgoingMessage } = require('http'); |
|||
const { Writable } = require('stream'); |
|||
const assert = require('assert'); |
|||
|
|||
// check that OutgoingMessage can be used without a proper Socket
|
|||
// Fixes: https://github.com/nodejs/node/issues/14386
|
|||
// Fixes: https://github.com/nodejs/node/issues/14381
|
|||
|
|||
class Response extends OutgoingMessage { |
|||
constructor() { |
|||
super({ method: 'GET', httpVersionMajor: 1, httpVersionMinor: 1 }); |
|||
} |
|||
|
|||
_implicitHeader() {} |
|||
} |
|||
|
|||
const res = new Response(); |
|||
const ws = new Writable({ |
|||
write: common.mustCall((chunk, encoding, callback) => { |
|||
assert(chunk.toString().match(/hello world/)); |
|||
setImmediate(callback); |
|||
}) |
|||
}); |
|||
|
|||
res.socket = ws; |
|||
ws._httpMessage = res; |
|||
res.connection = ws; |
|||
|
|||
res.end('hello world'); |
@ -0,0 +1,27 @@ |
|||
'use strict'; |
|||
|
|||
const common = require('../common'); |
|||
const { ServerResponse } = require('http'); |
|||
const { Writable } = require('stream'); |
|||
const assert = require('assert'); |
|||
|
|||
// check that ServerResponse can be used without a proper Socket
|
|||
// Fixes: https://github.com/nodejs/node/issues/14386
|
|||
// Fixes: https://github.com/nodejs/node/issues/14381
|
|||
|
|||
const res = new ServerResponse({ |
|||
method: 'GET', |
|||
httpVersionMajor: 1, |
|||
httpVersionMinor: 1 |
|||
}); |
|||
|
|||
const ws = new Writable({ |
|||
write: common.mustCall((chunk, encoding, callback) => { |
|||
assert(chunk.toString().match(/hello world/)); |
|||
setImmediate(callback); |
|||
}) |
|||
}); |
|||
|
|||
res.assignSocket(ws); |
|||
|
|||
res.end('hello world'); |
Loading…
Reference in new issue