crypto: fix memory leak in ECDH::SetPrivateKey

PR-URL: https://github.com/nodejs/node/pull/2375 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
10 years ago · 12ab8cfb9c
1 changed files with 5 additions and 1 deletions
--- a/src/node_crypto.cc
+++ b/src/node_crypto.cc
@ -4570,9 +4570,13 @@ void ECDH::SetPrivateKey(const FunctionCallbackInfo<Value>& args) {
  if (priv == nullptr)
    return env->ThrowError("Failed to convert Buffer to BN");

-  if (!EC_KEY_set_private_key(ecdh->key_, priv))
+  int result = EC_KEY_set_private_key(ecdh->key_, priv);
+  BN_free(priv);
+
+  if (!result) {
    return env->ThrowError("Failed to convert BN to a private key");
  }
+}


 void ECDH::SetPublicKey(const FunctionCallbackInfo<Value>& args) {