mirror of https://github.com/lukechilds/node.git
Browse Source
OutgoingMessage should be a write-only stream, and it shouldn't be piped. This commit disables the `pipe` method by throwing an exception (if this method is called). PR-URL: https://github.com/nodejs/node/pull/14358 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>v6
committed by
Matteo Collina
2 changed files with 19 additions and 0 deletions
@ -0,0 +1,15 @@ |
|||||
|
'use strict'; |
||||
|
const assert = require('assert'); |
||||
|
const common = require('../common'); |
||||
|
const OutgoingMessage = require('_http_outgoing').OutgoingMessage; |
||||
|
|
||||
|
// Verify that an error is thrown upon a call to `OutgoingMessage.pipe`.
|
||||
|
|
||||
|
const outgoingMessage = new OutgoingMessage(); |
||||
|
assert.throws( |
||||
|
common.mustCall(() => { outgoingMessage.pipe(outgoingMessage); }), |
||||
|
(err) => { |
||||
|
return ((err instanceof Error) && /Cannot pipe, not readable/.test(err)); |
||||
|
}, |
||||
|
'OutgoingMessage.pipe should throw an error' |
||||
|
); |
Loading…
Reference in new issue