mirror of https://github.com/lukechilds/node.git
Browse Source
Fix module loading of third-party modules in the REPL by inheriting
module.paths from the REPL's parent module.
Commit ee72ee7
("module,repl: remove repl require() hack") introduced
a regression where require() of modules in node_modules directories
no longer worked in the REPL (and fortunately only in the REPL.)
It turns out we didn't have test coverage for that but we do now.
Fixes: https://github.com/nodejs/node/issues/4208
PR-URL: https://github.com/nodejs/node/pull/4215
Reviewed-By: Roman Reiss <me@silverwind.io>
process-exit-stdio-flushing
Ben Noordhuis
9 years ago
3 changed files with 38 additions and 0 deletions
@ -0,0 +1,33 @@ |
|||
'use strict'; |
|||
|
|||
const common = require('../common'); |
|||
const assert = require('assert'); |
|||
const net = require('net'); |
|||
|
|||
process.chdir(common.fixturesDir); |
|||
const repl = require('repl'); |
|||
|
|||
const server = net.createServer(conn => { |
|||
repl.start('', conn).on('exit', () => { |
|||
conn.destroy(); |
|||
server.close(); |
|||
}); |
|||
}); |
|||
|
|||
const host = common.localhostIPv4; |
|||
const port = common.PORT; |
|||
const options = { host, port }; |
|||
|
|||
var answer = ''; |
|||
server.listen(options, function() { |
|||
const conn = net.connect(options); |
|||
conn.setEncoding('utf8'); |
|||
conn.on('data', data => answer += data); |
|||
conn.write('require("baz")\n.exit\n'); |
|||
}); |
|||
|
|||
process.on('exit', function() { |
|||
assert.strictEqual(false, /Cannot find module/.test(answer)); |
|||
assert.strictEqual(false, /Error/.test(answer)); |
|||
assert.strictEqual(true, /eye catcher/.test(answer)); |
|||
}); |
Loading…
Reference in new issue