Browse Source

test: clarify dropMembership() call

According to docs, dropMembership() is automatically called
by the kernel when the socket is closed, and most apps will
never need to call it. It's called here as a sanity check
only so let's note that with a comment.

Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: https://github.com/nodejs/io.js/pull/2062
v4.0.0-rc
Rich Trott 10 years ago
parent
commit
226b8e0cf8
  1. 6
      test/internet/test-dgram-multicast-multi-process.js

6
test/internet/test-dgram-multicast-multi-process.js

@ -3,7 +3,6 @@ var common = require('../common'),
assert = require('assert'), assert = require('assert'),
dgram = require('dgram'), dgram = require('dgram'),
util = require('util'), util = require('util'),
assert = require('assert'),
Buffer = require('buffer').Buffer, Buffer = require('buffer').Buffer,
fork = require('child_process').fork, fork = require('child_process').fork,
LOCAL_BROADCAST_HOST = '224.0.0.114', LOCAL_BROADCAST_HOST = '224.0.0.114',
@ -183,10 +182,9 @@ if (process.argv[2] === 'child') {
process.send({ message: buf.toString() }); process.send({ message: buf.toString() });
if (receivedMessages.length == messages.length) { if (receivedMessages.length == messages.length) {
// .dropMembership() not strictly needed but here as a sanity check
listenSocket.dropMembership(LOCAL_BROADCAST_HOST); listenSocket.dropMembership(LOCAL_BROADCAST_HOST);
process.nextTick(function() {
process.nextTick(function() { // TODO should be changed to below.
// listenSocket.dropMembership(LOCAL_BROADCAST_HOST, function() {
listenSocket.close(); listenSocket.close();
}); });
} }

Loading…
Cancel
Save