lukechilds
/
node
mirror of https://github.com/lukechilds/node.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
Browse Source

test: eliminate multicast test FreeBSD flakiness 

test-dgram-multicast-multi-process was flaky on FreeBSD and Raspeberry
Pi. This refactoring fixes the issue by eliminating a race condition.

Fixes: https://github.com/nodejs/node/issues/2474
PR-URL: https://github.com/nodejs/node/pull/4042
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
v5.x
Rich Trott 9 years ago
committed by Rod Vagg
parent
c93e2678f0
commit
22b0971222
1 changed files with 150 additions and 151 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Split View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 147
      test/internet/test-dgram-multicast-multi-process.js

147
test/internet/test-dgram-multicast-multi-process.js
View File

@ -1,53 +1,36 @@
'use strict';
var common = require('../common'),
assert = require('assert'),
dgram = require('dgram'),
util = require('util'),
Buffer = require('buffer').Buffer,
fork = require('child_process').fork,
LOCAL_BROADCAST_HOST = '224.0.0.114',
TIMEOUT = common.platformTimeout(5000),
messages = [
const common = require('../common');
const assert = require('assert');
const dgram = require('dgram');
const fork = require('child_process').fork;
const LOCAL_BROADCAST_HOST = '224.0.0.114';
const TIMEOUT = common.platformTimeout(5000);
const messages = [
new Buffer('First message to send'),
new Buffer('Second message to send'),
new Buffer('Third message to send'),
new Buffer('Fourth message to send')
];
];
const workers = {};
const listeners = 3;
if (process.argv[2] !== 'child') {
var workers = {},
listeners = 3,
listening = 0,
dead = 0,
i = 0,
done = 0,
timer = null;
//exit the test if it doesn't succeed within TIMEOUT
timer = setTimeout(function() {
console.error('[PARENT] Responses were not received within %d ms.',
TIMEOUT);
console.error('[PARENT] Fail');
killChildren(workers);
process.exit(1);
}, TIMEOUT);
// Skip test in FreeBSD jails.
if (common.inFreeBSDJail) {
console.log('1..0 # Skipped: In a FreeBSD jail');
return;
}
//launch child processes
for (var x = 0; x < listeners; x++) {
(function() {
var worker = fork(process.argv[1], ['child']);
function launchChildProcess(index) {
const worker = fork(__filename, ['child']);
workers[worker.pid] = worker;
worker.messagesReceived = [];
//handle the death of workers
// Handle the death of workers.
worker.on('exit', function(code, signal) {
// don't consider this the true death if the
// worker has finished successfully
// or if the exit code is 0
// Don't consider this the true death if the worker has finished
// successfully or if the exit code is 0.
if (worker.isDone || code === 0) {
return;
}
@ -61,9 +44,6 @@ if (process.argv[2] !== 'child') {
if (dead === listeners) {
console.error('[PARENT] All workers have died.');
console.error('[PARENT] Fail');
killChildren(workers);
process.exit(1);
}
});
@ -73,11 +53,12 @@ if (process.argv[2] !== 'child') {
listening += 1;
if (listening === listeners) {
//all child process are listening, so start sending
// All child process are listening, so start sending.
sendSocket.sendNext();
}
return;
}
else if (msg.message) {
if (msg.message) {
worker.messagesReceived.push(msg.message);
if (worker.messagesReceived.length === messages.length) {
@ -93,7 +74,7 @@ if (process.argv[2] !== 'child') {
'required number of messages. Will now compare.');
Object.keys(workers).forEach(function(pid) {
var worker = workers[pid];
const worker = workers[pid];
var count = 0;
@ -109,7 +90,7 @@ if (process.argv[2] !== 'child') {
console.error('[PARENT] %d received %d matching messages.',
worker.pid, count);
assert.equal(count, messages.length,
assert.strictEqual(count, messages.length,
'A worker received an invalid multicast message');
});
@ -119,16 +100,44 @@ if (process.argv[2] !== 'child') {
}
}
});
})(x);
}
function killChildren(children) {
Object.keys(children).forEach(function(key) {
const child = children[key];
child.kill();
});
}
if (process.argv[2] !== 'child') {
var listening = 0;
var dead = 0;
var i = 0;
var done = 0;
// Exit the test if it doesn't succeed within TIMEOUT.
var timer = setTimeout(function() {
console.error('[PARENT] Responses were not received within %d ms.',
TIMEOUT);
console.error('[PARENT] Fail');
killChildren(workers);
process.exit(1);
}, TIMEOUT);
// Launch child processes.
for (var x = 0; x < listeners; x++) {
launchChildProcess(x);
}
var sendSocket = dgram.createSocket('udp4');
// FIXME a libuv limitation makes it necessary to bind()
// before calling any of the set*() functions - the bind()
// call is what creates the actual socket...
// FIXME: a libuv limitation makes it necessary to bind()
// before calling any of the set*() functions. The bind()
// call is what creates the actual socket.
sendSocket.bind();
// The socket is actually created async now
// The socket is actually created async now.
sendSocket.on('listening', function() {
sendSocket.setTTL(1);
sendSocket.setBroadcast(true);
@ -141,7 +150,7 @@ if (process.argv[2] !== 'child') {
});
sendSocket.sendNext = function() {
var buf = messages[i++];
const buf = messages[i++];
if (!buf) {
try { sendSocket.close(); } catch (e) {}
@ -151,38 +160,34 @@ if (process.argv[2] !== 'child') {
sendSocket.send(buf, 0, buf.length,
common.PORT, LOCAL_BROADCAST_HOST, function(err) {
if (err) throw err;
console.error('[PARENT] sent %s to %s:%s',
util.inspect(buf.toString()),
console.error('[PARENT] sent "%s" to %s:%s',
buf.toString(),
LOCAL_BROADCAST_HOST, common.PORT);
process.nextTick(sendSocket.sendNext);
});
};
function killChildren(children) {
Object.keys(children).forEach(function(key) {
var child = children[key];
child.kill();
});
}
}
if (process.argv[2] === 'child') {
var receivedMessages = [];
var listenSocket = dgram.createSocket({
const receivedMessages = [];
const listenSocket = dgram.createSocket({
type: 'udp4',
reuseAddr: true
});
listenSocket.on('listening', function() {
listenSocket.addMembership(LOCAL_BROADCAST_HOST);
listenSocket.on('message', function(buf, rinfo) {
console.error('[CHILD] %s received %s from %j', process.pid,
util.inspect(buf.toString()), rinfo);
console.error('[CHILD] %s received "%s" from %j', process.pid,
buf.toString(), rinfo);
receivedMessages.push(buf);
process.send({ message: buf.toString() });
if (receivedMessages.length == messages.length) {
// .dropMembership() not strictly needed but here as a sanity check
// .dropMembership() not strictly needed but here as a sanity check.
listenSocket.dropMembership(LOCAL_BROADCAST_HOST);
process.nextTick(function() {
listenSocket.close();
@ -191,21 +196,15 @@ if (process.argv[2] === 'child') {
});
listenSocket.on('close', function() {
//HACK: Wait to exit the process to ensure that the parent
//process has had time to receive all messages via process.send()
//This may be indicitave of some other issue.
// HACK: Wait to exit the process to ensure that the parent
// process has had time to receive all messages via process.send()
// This may be indicative of some other issue.
setTimeout(function() {
process.exit();
}, 1000);
}, common.platformTimeout(1000));
});
listenSocket.on('listening', function() {
process.send({ listening: true });
});
listenSocket.bind(common.PORT);
listenSocket.on('listening', function() {
listenSocket.addMembership(LOCAL_BROADCAST_HOST);
});
}

Write Preview
Loading…
Cancel
Save