Browse Source

addons: remove semicolons from after module definition

Having semicolons there runs counter to our documentation and illicits
warnings in pedantic mode. This removes semicolons from after uses of
NODE_MODULE and NODE_MODULE_CONTEXT_AWARE_BUILTIN.

PR-URL: https://github.com/nodejs/node/pull/12919
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
v6
Gabriel Schulhof 8 years ago
committed by Anna Henningsen
parent
commit
276720921b
No known key found for this signature in database GPG Key ID: D8B9F5AEAE84E4CF
  1. 2
      benchmark/misc/function_call/binding.cc
  2. 2
      doc/api/addons.md
  3. 2
      src/node.cc
  4. 2
      src/node_contextify.cc
  5. 2
      test/addons/async-hello-world/binding.cc
  6. 2
      test/addons/at-exit/binding.cc
  7. 2
      test/addons/buffer-free-callback/binding.cc
  8. 2
      test/addons/hello-world-function-export/binding.cc
  9. 2
      test/addons/hello-world/binding.cc
  10. 2
      test/addons/load-long-path/binding.cc
  11. 2
      test/addons/null-buffer-neuter/binding.cc
  12. 2
      test/addons/parse-encoding/binding.cc
  13. 2
      test/addons/repl-domain-abort/binding.cc
  14. 2
      test/addons/stringbytes-external-exceed-max/binding.cc
  15. 2
      test/addons/symlinked-module/binding.cc

2
benchmark/misc/function_call/binding.cc

@ -14,4 +14,4 @@ extern "C" void init (Local<Object> target) {
NODE_SET_METHOD(target, "hello", Hello);
}
NODE_MODULE(binding, init);
NODE_MODULE(binding, init)

2
doc/api/addons.md

@ -1116,7 +1116,7 @@ void init(Local<Object> exports) {
AtExit(at_exit_cb1, exports->GetIsolate());
}
NODE_MODULE(addon, init);
NODE_MODULE(addon, init)
} // namespace demo
```

2
src/node.cc

@ -4618,5 +4618,5 @@ int Start(int argc, char** argv) {
#if !HAVE_INSPECTOR
static void InitEmptyBindings() {}
NODE_MODULE_CONTEXT_AWARE_BUILTIN(inspector, InitEmptyBindings);
NODE_MODULE_CONTEXT_AWARE_BUILTIN(inspector, InitEmptyBindings)
#endif // !HAVE_INSPECTOR

2
src/node_contextify.cc

@ -1033,4 +1033,4 @@ void InitContextify(Local<Object> target,
} // anonymous namespace
} // namespace node
NODE_MODULE_CONTEXT_AWARE_BUILTIN(contextify, node::InitContextify);
NODE_MODULE_CONTEXT_AWARE_BUILTIN(contextify, node::InitContextify)

2
test/addons/async-hello-world/binding.cc

@ -77,4 +77,4 @@ void init(v8::Local<v8::Object> exports, v8::Local<v8::Object> module) {
NODE_SET_METHOD(module, "exports", Method);
}
NODE_MODULE(binding, init);
NODE_MODULE(binding, init)

2
test/addons/at-exit/binding.cc

@ -40,4 +40,4 @@ void init(Local<Object> exports) {
atexit(sanity_check);
}
NODE_MODULE(binding, init);
NODE_MODULE(binding, init)

2
test/addons/buffer-free-callback/binding.cc

@ -41,4 +41,4 @@ void init(v8::Local<v8::Object> exports) {
NODE_SET_METHOD(exports, "check", Check);
}
NODE_MODULE(binding, init);
NODE_MODULE(binding, init)

2
test/addons/hello-world-function-export/binding.cc

@ -11,4 +11,4 @@ void init(v8::Local<v8::Object> exports, v8::Local<v8::Object> module) {
NODE_SET_METHOD(module, "exports", Method);
}
NODE_MODULE(binding, init);
NODE_MODULE(binding, init)

2
test/addons/hello-world/binding.cc

@ -11,4 +11,4 @@ void init(v8::Local<v8::Object> exports) {
NODE_SET_METHOD(exports, "hello", Method);
}
NODE_MODULE(binding, init);
NODE_MODULE(binding, init)

2
test/addons/load-long-path/binding.cc

@ -10,4 +10,4 @@ void init(v8::Local<v8::Object> exports) {
NODE_SET_METHOD(exports, "hello", Method);
}
NODE_MODULE(binding, init);
NODE_MODULE(binding, init)

2
test/addons/null-buffer-neuter/binding.cc

@ -38,4 +38,4 @@ void init(v8::Local<v8::Object> exports) {
NODE_SET_METHOD(exports, "run", Run);
}
NODE_MODULE(binding, init);
NODE_MODULE(binding, init)

2
test/addons/parse-encoding/binding.cc

@ -35,4 +35,4 @@ void Initialize(v8::Local<v8::Object> exports) {
} // anonymous namespace
NODE_MODULE(binding, Initialize);
NODE_MODULE(binding, Initialize)

2
test/addons/repl-domain-abort/binding.cc

@ -44,4 +44,4 @@ void init(Local<Object> exports) {
NODE_SET_METHOD(exports, "method", Method);
}
NODE_MODULE(binding, init);
NODE_MODULE(binding, init)

2
test/addons/stringbytes-external-exceed-max/binding.cc

@ -21,4 +21,4 @@ void init(v8::Local<v8::Object> exports) {
NODE_SET_METHOD(exports, "ensureAllocation", EnsureAllocation);
}
NODE_MODULE(binding, init);
NODE_MODULE(binding, init)

2
test/addons/symlinked-module/binding.cc

@ -10,4 +10,4 @@ void init(v8::Local<v8::Object> exports) {
NODE_SET_METHOD(exports, "hello", Method);
}
NODE_MODULE(binding, init);
NODE_MODULE(binding, init)

Loading…
Cancel
Save