Browse Source

src: fix readability/braces cpplint warnings

PR-URL: https://github.com/nodejs/node/pull/7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
v7.x
Ben Noordhuis 8 years ago
parent
commit
29228c4089
  1. 4
      src/cares_wrap.cc
  2. 10
      src/inspector_agent.cc
  3. 4
      src/node_http_parser.cc
  4. 2
      src/node_watchdog.cc

4
src/cares_wrap.cc

@ -371,11 +371,11 @@ class QueryWrap : public AsyncWrap {
// Subclasses should implement the appropriate Parse method. // Subclasses should implement the appropriate Parse method.
virtual void Parse(unsigned char* buf, int len) { virtual void Parse(unsigned char* buf, int len) {
UNREACHABLE(); UNREACHABLE();
}; }
virtual void Parse(struct hostent* host) { virtual void Parse(struct hostent* host) {
UNREACHABLE(); UNREACHABLE();
}; }
}; };

10
src/inspector_agent.cc

@ -575,23 +575,23 @@ Agent::~Agent() {
void Agent::Start(v8::Platform* platform, int port, bool wait) { void Agent::Start(v8::Platform* platform, int port, bool wait) {
impl->Start(platform, port, wait); impl->Start(platform, port, wait);
}; }
void Agent::Stop() { void Agent::Stop() {
impl->Stop(); impl->Stop();
}; }
bool Agent::IsStarted() { bool Agent::IsStarted() {
return impl->IsStarted(); return impl->IsStarted();
}; }
bool Agent::IsConnected() { bool Agent::IsConnected() {
return impl->IsConnected(); return impl->IsConnected();
}; }
void Agent::WaitForDisconnect() { void Agent::WaitForDisconnect() {
impl->WaitForDisconnect(); impl->WaitForDisconnect();
}; }
} // namespace inspector } // namespace inspector
} // namespace node } // namespace node

4
src/node_http_parser.cc

@ -107,9 +107,9 @@ struct StringPtr {
void Update(const char* str, size_t size) { void Update(const char* str, size_t size) {
if (str_ == nullptr) if (str_ == nullptr) {
str_ = str; str_ = str;
else if (on_heap_ || str_ + size_ != str) { } else if (on_heap_ || str_ + size_ != str) {
// Non-consecutive input, make a copy on the heap. // Non-consecutive input, make a copy on the heap.
// TODO(bnoordhuis) Use slab allocation, O(n) allocs is bad. // TODO(bnoordhuis) Use slab allocation, O(n) allocs is bad.
char* s = new char[size_ + size]; char* s = new char[size_ + size];

2
src/node_watchdog.cc

@ -292,7 +292,7 @@ SigintWatchdogHelper::SigintWatchdogHelper()
CHECK_EQ(0, uv_mutex_init(&mutex_)); CHECK_EQ(0, uv_mutex_init(&mutex_));
CHECK_EQ(0, uv_mutex_init(&list_mutex_)); CHECK_EQ(0, uv_mutex_init(&list_mutex_));
}; }
SigintWatchdogHelper::~SigintWatchdogHelper() { SigintWatchdogHelper::~SigintWatchdogHelper() {

Loading…
Cancel
Save