Browse Source

test: move timer-dependent test to sequential

`test-regress-GH-897` is dependent on a timer firing within a period of
time. Especially on some of the FreeBSD hosts on CI, we have seen tests
like that fail when run in parallel. (This may have nothing to do with
FreeBSD and may just mean that the hosts are resource-constrained.) Move
this test to sequential as we have done with several other
timer-dependent tests recently.

The test has also been refactored and documented via comments.

PR-URL: https://github.com/nodejs/node/pull/9487
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
v7.x
Rich Trott 8 years ago
committed by Anna Henningsen
parent
commit
2a9625656d
No known key found for this signature in database GPG Key ID: D8B9F5AEAE84E4CF
  1. 15
      test/parallel/test-regress-GH-897.js
  2. 17
      test/sequential/test-regress-GH-897.js

15
test/parallel/test-regress-GH-897.js

@ -1,15 +0,0 @@
'use strict';
require('../common');
var assert = require('assert');
var t = Date.now();
var diff;
setTimeout(function() {
diff = Date.now() - t;
console.error(diff);
}, 0.1);
process.on('exit', function() {
assert.ok(diff < 100);
});

17
test/sequential/test-regress-GH-897.js

@ -0,0 +1,17 @@
'use strict';
// Test for bug where a timer duration greater than 0 ms but less than 1 ms
// resulted in the duration being set for 1000 ms. The expected behavior is
// that the timeout would be set for 1 ms, and thus fire more-or-less
// immediately.
//
// Ref: https://github.com/nodejs/node-v0.x-archive/pull/897
const common = require('../common');
const assert = require('assert');
const t = Date.now();
setTimeout(common.mustCall(function() {
const diff = Date.now() - t;
assert.ok(diff < 100, `timer fired after ${diff} ms`);
}), 0.1);
Loading…
Cancel
Save