Browse Source

test: fix sequential test-net-connect-local-error

Fixed sequential test-net-connect-local-error by swapping port
and localPort in net.connect options.

PR-URL: https://github.com/nodejs/node/pull/13064
Fixes: https://github.com/nodejs/node/issues/13055
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
v6
Sebastian Plesciuc 8 years ago
committed by Refael Ackermann
parent
commit
3429c90f42
  1. 23
      test/sequential/test-net-connect-local-error.js

23
test/sequential/test-net-connect-local-error.js

@ -3,28 +3,23 @@ const common = require('../common');
const assert = require('assert'); const assert = require('assert');
const net = require('net'); const net = require('net');
// EADDRINUSE is expected to occur on FreeBSD
// Ref: https://github.com/nodejs/node/issues/13055
const expectedErrorCodes = ['ECONNREFUSED', 'EADDRINUSE'];
const client = net.connect({ const client = net.connect({
port: common.PORT + 1, port: common.PORT,
localPort: common.PORT, localPort: common.PORT + 1,
localAddress: common.localhostIPv4 localAddress: common.localhostIPv4
}); });
client.on('error', common.mustCall(function onError(err) { client.on('error', common.mustCall(function onError(err) {
assert.ok(expectedErrorCodes.includes(err.code));
assert.strictEqual(err.syscall, 'connect'); assert.strictEqual(err.syscall, 'connect');
assert.strictEqual(err.code, 'ECONNREFUSED'); assert.strictEqual(err.localPort, common.PORT + 1);
assert.strictEqual( assert.strictEqual(err.localAddress, common.localhostIPv4);
err.localPort,
common.PORT,
`${err.localPort} !== ${common.PORT} in ${err}`
);
assert.strictEqual(
err.localAddress,
common.localhostIPv4,
`${err.localAddress} !== ${common.localhostIPv4} in ${err}`
);
assert.strictEqual( assert.strictEqual(
err.message, err.message,
`connect ECONNREFUSED ${err.address}:${err.port} ` + `connect ${err.code} ${err.address}:${err.port} ` +
`- Local (${err.localAddress}:${err.localPort})` `- Local (${err.localAddress}:${err.localPort})`
); );
})); }));

Loading…
Cancel
Save