Browse Source

Emit a better error message when something strange is sent to OutgoingMessage#write

v0.7.4-release
isaacs 15 years ago
committed by Ryan Dahl
parent
commit
3892628657
  1. 7
      lib/http.js

7
lib/http.js

@ -10,6 +10,7 @@ function debug (x) {
var sys = require('sys'); var sys = require('sys');
var net = require('net'); var net = require('net');
var events = require('events'); var events = require('events');
var Buffer = require('buffer').Buffer;
var FreeList = require('freelist').FreeList; var FreeList = require('freelist').FreeList;
var HTTPParser = process.binding('http_parser').HTTPParser; var HTTPParser = process.binding('http_parser').HTTPParser;
@ -345,6 +346,12 @@ OutgoingMessage.prototype.write = function (chunk, encoding) {
throw new Error("This type of response MUST NOT have a body."); throw new Error("This type of response MUST NOT have a body.");
} }
if (typeof chunk !== "string"
&& !(chunk instanceof Buffer)
&& !Array.isArray(chunk)) {
throw new TypeError("first argument must be a string, Array, or Buffer");
}
encoding = encoding || "ascii"; encoding = encoding || "ascii";
if (this.chunkedEncoding) { if (this.chunkedEncoding) {
if (typeof chunk == 'string') { if (typeof chunk == 'string') {

Loading…
Cancel
Save