Browse Source

net: remove unnecessary variables

V8 is smart enough to optimize the length property checking when
iterating over an array with a for loop.

PR-URL: https://github.com/nodejs/node/pull/8112
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
v4.x
Brian White 9 years ago
committed by Myles Borins
parent
commit
3906206ecc
  1. 10
      lib/net.js

10
lib/net.js

@ -59,9 +59,8 @@ exports.createServer = function(options, connectionListener) {
// connect(path, [cb]); // connect(path, [cb]);
// //
exports.connect = exports.createConnection = function() { exports.connect = exports.createConnection = function() {
const argsLen = arguments.length; var args = new Array(arguments.length);
var args = new Array(argsLen); for (var i = 0; i < arguments.length; i++)
for (var i = 0; i < argsLen; i++)
args[i] = arguments[i]; args[i] = arguments[i];
args = normalizeConnectArgs(args); args = normalizeConnectArgs(args);
debug('createConnection', args); debug('createConnection', args);
@ -875,9 +874,8 @@ Socket.prototype.connect = function(options, cb) {
// Old API: // Old API:
// connect(port, [host], [cb]) // connect(port, [host], [cb])
// connect(path, [cb]); // connect(path, [cb]);
const argsLen = arguments.length; var args = new Array(arguments.length);
var args = new Array(argsLen); for (var i = 0; i < arguments.length; i++)
for (var i = 0; i < argsLen; i++)
args[i] = arguments[i]; args[i] = arguments[i];
args = normalizeConnectArgs(args); args = normalizeConnectArgs(args);
return Socket.prototype.connect.apply(this, args); return Socket.prototype.connect.apply(this, args);

Loading…
Cancel
Save