Browse Source

repl: use String#repeat instead of Array#join

String#repeat is quite a bit faster than new Array().join().

PR-URL: https://github.com/nodejs/node/pull/3900
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
process-exit-stdio-flushing
Evan Lucas 9 years ago
parent
commit
50125e27b7
  1. 6
      lib/repl.js

6
lib/repl.js

@ -568,7 +568,8 @@ REPLServer.prototype.displayPrompt = function(preserveCursor) {
var prompt = this._initialPrompt; var prompt = this._initialPrompt;
if (this.bufferedCommand.length) { if (this.bufferedCommand.length) {
prompt = '...'; prompt = '...';
var levelInd = new Array(this.lines.level.length).join('..'); const len = this.lines.level.length ? this.lines.level.length - 1 : 0;
const levelInd = '..'.repeat(len);
prompt += levelInd + ' '; prompt += levelInd + ' ';
} }
@ -920,7 +921,8 @@ REPLServer.prototype.memory = function memory(cmd) {
// save the line so I can do magic later // save the line so I can do magic later
if (cmd) { if (cmd) {
// TODO should I tab the level? // TODO should I tab the level?
self.lines.push(new Array(self.lines.level.length).join(' ') + cmd); const len = self.lines.level.length ? self.lines.level.length - 1 : 0;
self.lines.push(' '.repeat(len) + cmd);
} else { } else {
// I don't want to not change the format too much... // I don't want to not change the format too much...
self.lines.push(''); self.lines.push('');

Loading…
Cancel
Save