test: refactored test-repl-persistent-history

PR-URL: https://github.com/nodejs/node/pull/12703
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

test/parallel/test-repl-persistent-history.js

@@ -204,12 +204,6 @@ const tests = [
 const numtests = tests.length;
 
 
-let testsNotRan = tests.length;
-
-process.on('beforeExit', () =>
-  assert.strictEqual(testsNotRan, 0)
-);
-
 function cleanupTmpFile() {
   try {
     // Write over the file, clearing any history
@@ -225,6 +219,8 @@ function cleanupTmpFile() {
 fs.createReadStream(historyFixturePath)
   .pipe(fs.createWriteStream(historyPath)).on('unpipe', () => runTest());
 
+const runTestWrap = common.mustCall(runTest, numtests);
+
 function runTest(assertCleaned) {
   const opts = tests.shift();
   if (!opts) return; // All done
@@ -294,8 +290,7 @@ function runTest(assertCleaned) {
       try {
         // Ensure everything that we expected was output
         assert.strictEqual(expected.length, 0);
-        testsNotRan--;
+        setImmediate(runTestWrap, cleaned);
-        setImmediate(runTest, cleaned);
       } catch (err) {
         console.error(`Failed test # ${numtests - tests.length}`);
         throw err;