Replace slow and broken for..in loops with faster for loops over the keys.

lib/child_process.js

@@ -76,11 +76,11 @@ ChildProcess.prototype.spawn = function (path, args, env) {
   args = args || [];
   env = env || process.env;
   var envPairs = [];
-  for (var key in env) {
+  var keys = Object.keys(env);
-    if (env.hasOwnProperty(key)) {
+  for (var index = 0, keysLength = keys.length; index < keysLength; index++) {
+    var key = keys[index];
     envPairs.push(key + "=" + env[key]);
   }
-  }
 
   var fds = this._internal.spawn(path, args, envPairs);
 

lib/dns.js

@@ -8,7 +8,9 @@ var activeWatchers = {};
 var timer = new process.Timer();
 
 timer.callback = function () {
-  for (var socket in activeWatchers) {
+  var sockets = Object.keys(activeWatchers);
+  for (var i = 0, l = sockets.length; i < l; i++) {
+    var socket = sockets[i];
     var s = parseInt(socket);
     channel.processFD( watchers[socket].read  ? s : dns.SOCKET_BAD
                      , watchers[socket].write ? s : dns.SOCKET_BAD
@@ -21,14 +23,17 @@ timer.callback = function () {
 function updateTimer() {
   timer.stop();
 
-  for (var socket in activeWatchers) { // if !empty(activeWatchers)
+  // Were just checking to see if activeWatchers is empty or not
+  for (var socket in activeWatchers) {
+    if (activeWatchers.hasOwnProperty(socket)) {
       var max = 20000;
       var timeout = channel.timeout(max);
 
       timer.start(timeout, 0);
-
+      // Short circuit the loop on first find.
       return;
     }
+  }
 }
 
 

lib/fs.js

@@ -490,7 +490,13 @@ var FileReadStream = fs.FileReadStream = function(path, options) {
   this.bufferSize = 4 * 1024;
 
   options = options || {};
-  for (var i in options) this[i] = options[i];
+
+  // Mixin options into this
+  var keys = Object.keys(options);
+  for (var index = 0, length = keys.length; index < length; index++) {
+    var key = keys[index];
+    this[key] = options[key];
+  }
 
   var self = this;
 
@@ -621,7 +627,13 @@ var FileWriteStream = fs.FileWriteStream = function(path, options) {
   this.mode = 0666;
 
   options = options || {};
-  for (var i in options) this[i] = options[i];
+
+  // Mixin options into this
+  var keys = Object.keys(options);
+  for (var index = 0, length = keys.length; index < length; index++) {
+    var key = keys[index];
+    this[key] = options[key];
+  }
 
   this.busy = false;
   this._queue = [];

lib/http.js

@@ -267,14 +267,18 @@ OutgoingMessage.prototype.sendHeaderLines = function (firstLine, headers) {
   // in the case of response it is: "HTTP/1.1 200 OK\r\n"
   var messageHeader = firstLine;
   var field, value;
-  for (var i in headers) {
+
-    if (headers[i] instanceof Array) {
+  if (headers) {
-      field = headers[i][0];
+    var keys = Object.keys(headers);
-      value = headers[i][1];
+    var isArray = (headers instanceof Array);
+    for (var i = 0, l = keys.length; i < l; i++) {
+      var key = keys[i];
+      if (isArray) {
+        field = headers[key][0];
+        value = headers[key][1];
       } else {
-      if (!headers.hasOwnProperty(i)) continue;
+        field = key;
-      field = i;
+        value = headers[key];
-      value = headers[i];
       }
 
       messageHeader += field + ": " + value + CRLF;
@@ -292,6 +296,7 @@ OutgoingMessage.prototype.sendHeaderLines = function (firstLine, headers) {
 
       }
     }
+  }
 
   // keep-alive logic
   if (sentConnectionHeader == false) {
@@ -696,12 +701,23 @@ exports.cat = function (url, encoding_, headers_) {
   var url = require("url").parse(url);
   
   var hasHost = false;
-  for (var i in headers) {
+  if (headers instanceof Array) {
-    if (i.toLowerCase() === "host") {
+    for (var i = 0, l = headers.length; i < l; i++) {
+      if (headers[i][0].toLowerCase() === 'host') {
         hasHost = true;
         break;
       }
     }
+  } else if (typeof headers === "Object") {
+    var keys = Object.keys(headers);
+    for (var i = 0, l = keys.length; i < l; i++) {
+      var key = keys[i];
+      if (key.toLowerCase() == 'host') {
+        hasHost = true;
+        break;
+      }
+    }
+  }
   if (!hasHost) headers["Host"] = url.hostname;
 
   var content = "";

lib/ini.js

@@ -42,24 +42,35 @@ function safe (val) {
   return (val+"").replace(/[\n\r]+/g, " ");
 }
 
+// ForEaches over an object. The only thing faster is to inline this function.
+function objectEach(obj, fn, thisObj) {
+  var keys, key, i, length;
+  keys = Object.keys(obj);
+  length = keys.length;
+  for (i = 0; i < length; i++) {
+    key = keys[i];
+    fn.call(thisObj, obj[key], key, obj);
+  }
+}
+
 exports.stringify = function (obj) {
   // if the obj has a "-" section, then do that first.
-  var ini = "";
+  var ini = [];
   if ("-" in obj) {
-    for (var key in obj["-"]) {
+    objectEach(obj["-"], function (value, key) {
-      ini += safe(key)+" = "+safe(obj["-"][key])+"\n";
+      ini[ini.length] = safe(key) + " = " + safe(value) + "\n";
-    }
+    });
   }
-  for (var section in obj) if (section !== "-") {
+  objectEach(obj, function (section, name) {
-    ini += "[" + safe(section) + "]\n";
+    if (name === "-") return;
-    for (var key in obj[section]) {
+    ini[ini.length] = "[" + safe(name) + "]\n";
-
+    objectEach(section, function (value, key) {
-      ini += safe(key) + ((obj[section][key] === true)
+      ini[ini.length] = safe(key) + ((value === true)
         ? "\n"
-        : " = "+safe(obj[section][key])+"\n");
+        : " = "+safe(value)+"\n");
-    }
+    });
-  }
+  });
-  return ini;
+  return ini.join("");
 };
 
 exports.encode = exports.stringify;

lib/querystring.js

@@ -55,9 +55,11 @@ QueryString.stringify = function (obj, sep, eq, name) {
   var s = [];
   var begin = name ? name + '[' : '';
   var end = name ? ']' : '';
-  for (var i in obj) if (obj.hasOwnProperty(i)) {
+  var keys = Object.keys(obj);
-    var n = begin + i + end;
+  for (var i = 0, l = keys.length; i < l; i++) {
-    s.push(QueryString.stringify(obj[i], sep, eq, n));
+    var key = keys[i];
+    var n = begin + key + end;
+    s.push(QueryString.stringify(obj[key], sep, eq, n));
   }
 
   stack.pop();
@@ -138,10 +140,14 @@ function mergeParams (params, addition) {
 };
 
 // Merge two *objects* together. If this is called, we've already ruled
-// out the simple cases, and need to do the for-in business.
+// out the simple cases, and need to do a loop.
 function mergeObjects (params, addition) {
-  for (var i in addition) if (i && addition.hasOwnProperty(i)) {
+  var keys = Object.keys(addition);
-    params[i] = mergeParams(params[i], addition[i]);
+  for (var i = 0, l = keys.length; i < l; i++) {
+    var key = keys[i];
+    if (key) {
+      params[key] = mergeParams(params[key], addition[key]);
+    }
   }
   return params;
 };

lib/url.js

@@ -56,7 +56,11 @@ function urlParse (url, parseQueryString) {
 
     // pull out the auth and port.
     var p = parseHost(out.host);
-    for (var i in p) out[i] = p[i];
+    var keys = Object.keys(p);
+    for (var i = 0, l = keys.length; i < l; i++) {
+      var key = keys[i];
+      out[key] = p[key];
+    }
     // we've indicated that there is a hostname, so even if it's empty, it has to be present.
     out.hostname = out.hostname || "";
   }

src/node.js

@@ -462,7 +462,9 @@ function findModulePath (id, dirs, callback) {
   ];
 
   var ext;
-  for (ext in extensionCache) {
+  var extensions = Object.keys(extensionCache);
+  for (var i = 0, l = extensions.length; i < l; i++) {
+    var ext = extensions[i];
     locations.push(path.join(dir, id + ext));
     locations.push(path.join(dir, id, 'index' + ext));
   }
@@ -504,7 +506,9 @@ function resolveModulePath(request, parent) {
     debug("RELATIVE: requested:" + request + " set ID to: "+id+" from "+parent.id);
 
     var exts = ['js', 'node'], ext;
-    for (ext in extensionCache) {
+    var extensions = Object.keys(extensionCache);
+    for (var i = 0, l = extensions.length; i < l; i++) {
+      var ext = extensions[i];
       exts.push(ext.slice(1));
     }