Browse Source

test: http2 client operations after destroy

PR-URL: https://github.com/nodejs/node/pull/16094
Ref: https://github.com/nodejs/node/issues/14985
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
v9.x-staging
Trivikram Kamat 7 years ago
committed by James M Snell
parent
commit
68df587b1e
  1. 49
      test/parallel/test-http2-client-destroy.js

49
test/parallel/test-http2-client-destroy.js

@ -71,19 +71,40 @@ const h2 = require('http2');
); );
} }
// test destroy before connect // test destroy before client operations
{ {
const server = h2.createServer(); const server = h2.createServer();
server.listen( server.listen(
0, 0,
common.mustCall(() => { common.mustCall(() => {
const client = h2.connect(`http://localhost:${server.address().port}`); const client = h2.connect(`http://localhost:${server.address().port}`);
const req = client.request();
const req = client.request({ ':path': '/' });
client.destroy(); client.destroy();
req.on('response', common.mustNotCall()); req.on('response', common.mustNotCall());
req.resume(); req.resume();
const sessionError = {
type: Error,
code: 'ERR_HTTP2_INVALID_SESSION',
message: 'The session has been destroyed'
};
common.expectsError(() => client.request(), sessionError);
common.expectsError(() => client.settings({}), sessionError);
common.expectsError(() => client.priority(req, {}), sessionError);
common.expectsError(() => client.shutdown(), sessionError);
// Wait for setImmediate call from destroy() to complete
// so that state.destroyed is set to true
setImmediate(() => {
common.expectsError(() => client.request(), sessionError);
common.expectsError(() => client.settings({}), sessionError);
common.expectsError(() => client.priority(req, {}), sessionError);
common.expectsError(() => client.shutdown(), sessionError);
common.expectsError(() => client.rstStream(req), sessionError);
});
req.on( req.on(
'end', 'end',
common.mustCall(() => { common.mustCall(() => {
@ -95,28 +116,6 @@ const h2 = require('http2');
); );
} }
// test destroy before request
{
const server = h2.createServer();
server.listen(
0,
common.mustCall(() => {
const client = h2.connect(`http://localhost:${server.address().port}`);
client.destroy();
assert.throws(
() => client.request({ ':path': '/' }),
common.expectsError({
code: 'ERR_HTTP2_INVALID_SESSION',
message: 'The session has been destroyed'
})
);
server.close();
})
);
}
// test destroy before goaway // test destroy before goaway
{ {
const server = h2.createServer(); const server = h2.createServer();

Loading…
Cancel
Save