mirror of https://github.com/lukechilds/node.git
Browse Source
socket.destroy() triggers a 'close' event from the socket which triggers the onClose handler of HTTPAgent which calls self.removeSocket(). So by calling self.removeSocket() prior to socket.destroy() we end up with two calls to self.removeSocket(). If there are pending requests, removeSocket ends up creating a new socket. So if there are pending requests, each time a request completes, we tear down one socket and create two more. So the total number of sockets grows exponentially and without regard for any maxSockets settings. This was noticed in https://github.com/nodejs/node/issues/4050. Let's get rid of the extra calls to removeSocket so we only call it once per completed request. PR-URL: https://github.com/nodejs/node/pull/4172 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com>process-exit-stdio-flushing
Dave
9 years ago
committed by
Fedor Indutny
2 changed files with 43 additions and 2 deletions
@ -0,0 +1,43 @@ |
|||
'use strict'; |
|||
const common = require('../common'); |
|||
const assert = require('assert'); |
|||
const http = require('http'); |
|||
|
|||
const MAX_SOCKETS = 2; |
|||
|
|||
const agent = new http.Agent({ |
|||
keepAlive: true, |
|||
keepAliveMsecs: 1000, |
|||
maxSockets: MAX_SOCKETS, |
|||
maxFreeSockets: 2 |
|||
}); |
|||
|
|||
const server = http.createServer(function(req, res) { |
|||
res.end('hello world'); |
|||
}); |
|||
|
|||
function get(path, callback) { |
|||
return http.get({ |
|||
host: 'localhost', |
|||
port: common.PORT, |
|||
agent: agent, |
|||
path: path |
|||
}, callback); |
|||
} |
|||
|
|||
server.listen(common.PORT, function() { |
|||
var finished = 0; |
|||
const num_requests = 6; |
|||
for (var i = 0; i < num_requests; i++) { |
|||
const request = get('/1', function() { |
|||
}); |
|||
request.on('response', function() { |
|||
request.abort(); |
|||
const sockets = agent.sockets[Object.keys(agent.sockets)[0]]; |
|||
assert(sockets.length <= MAX_SOCKETS); |
|||
if (++finished === num_requests) { |
|||
server.close(); |
|||
} |
|||
}); |
|||
} |
|||
}); |
Loading…
Reference in new issue