Browse Source

src: describe what NODE_MODULE_VERSION is for

Current comment described what to do with it when the ABI changes, but
implied that Node.js would load modules with newer ABI numbers, which it
will not.

PR-URL: https://github.com/nodejs/node/pull/10414
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
v6.x
Sam Roberts 8 years ago
committed by Myles Borins
parent
commit
7da06088eb
  1. 3
      src/node_version.h

3
src/node_version.h

@ -47,6 +47,9 @@
(minor) == NODE_MINOR_VERSION && (patch) <= NODE_PATCH_VERSION)) (minor) == NODE_MINOR_VERSION && (patch) <= NODE_PATCH_VERSION))
/** /**
* Node.js will refuse to load modules that weren't compiled against its own
* module ABI number, exposed as the process.versions.modules property.
*
* When this version number is changed, node.js will refuse * When this version number is changed, node.js will refuse
* to load older modules. This should be done whenever * to load older modules. This should be done whenever
* an API is broken in the C++ side, including in v8 or * an API is broken in the C++ side, including in v8 or

Loading…
Cancel
Save