Browse Source

build: ignore empty folders in test-addons

Fixes: https://github.com/nodejs/node/issues/14843
PR-URL: https://github.com/nodejs/node/pull/16031
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
v9.x-staging
Gregor 7 years ago
committed by Michael Dawson
parent
commit
7da45f87da
  1. 3
      Makefile

3
Makefile

@ -267,7 +267,10 @@ test/addons/.buildstamp: config.gypi \
test/addons/.docbuildstamp test/addons/.docbuildstamp
# Cannot use $(wildcard test/addons/*/) here, it's evaluated before # Cannot use $(wildcard test/addons/*/) here, it's evaluated before
# embedded addons have been generated from the documentation. # embedded addons have been generated from the documentation.
# Ignore folders without binding.gyp (#14843)
@for dirname in test/addons/*/; do \ @for dirname in test/addons/*/; do \
if [ ! -f "$$PWD/$${dirname}binding.gyp" ]; then \
continue; fi ; \
printf "\nBuilding addon $$PWD/$$dirname\n" ; \ printf "\nBuilding addon $$PWD/$$dirname\n" ; \
env MAKEFLAGS="-j1" $(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp \ env MAKEFLAGS="-j1" $(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp \
--loglevel=$(LOGLEVEL) rebuild \ --loglevel=$(LOGLEVEL) rebuild \

Loading…
Cancel
Save