Browse Source

crypto: merge Cipher and Decipher

v0.11.0-release
Fedor Indutny 12 years ago
parent
commit
83d17e509f
  1. 8
      lib/crypto.js
  2. 598
      src/node_crypto.cc
  3. 87
      src/node_crypto.h

8
lib/crypto.js

@ -216,7 +216,7 @@ exports.createCipher = exports.Cipher = Cipher;
function Cipher(cipher, password, options) { function Cipher(cipher, password, options) {
if (!(this instanceof Cipher)) if (!(this instanceof Cipher))
return new Cipher(cipher, password); return new Cipher(cipher, password);
this._binding = new binding.Cipher; this._binding = new binding.CipherBase(true);
this._binding.init(cipher, toBuf(password)); this._binding.init(cipher, toBuf(password));
this._decoder = null; this._decoder = null;
@ -276,7 +276,7 @@ exports.createCipheriv = exports.Cipheriv = Cipheriv;
function Cipheriv(cipher, key, iv, options) { function Cipheriv(cipher, key, iv, options) {
if (!(this instanceof Cipheriv)) if (!(this instanceof Cipheriv))
return new Cipheriv(cipher, key, iv); return new Cipheriv(cipher, key, iv);
this._binding = new binding.Cipher(); this._binding = new binding.CipherBase(true);
this._binding.initiv(cipher, toBuf(key), toBuf(iv)); this._binding.initiv(cipher, toBuf(key), toBuf(iv));
this._decoder = null; this._decoder = null;
@ -298,7 +298,7 @@ function Decipher(cipher, password, options) {
if (!(this instanceof Decipher)) if (!(this instanceof Decipher))
return new Decipher(cipher, password); return new Decipher(cipher, password);
this._binding = new binding.Decipher; this._binding = new binding.CipherBase(false);
this._binding.init(cipher, toBuf(password)); this._binding.init(cipher, toBuf(password));
this._decoder = null; this._decoder = null;
@ -321,7 +321,7 @@ function Decipheriv(cipher, key, iv, options) {
if (!(this instanceof Decipheriv)) if (!(this instanceof Decipheriv))
return new Decipheriv(cipher, key, iv); return new Decipheriv(cipher, key, iv);
this._binding = new binding.Decipher; this._binding = new binding.CipherBase(false);
this._binding.initiv(cipher, toBuf(key), toBuf(iv)); this._binding.initiv(cipher, toBuf(key), toBuf(iv));
this._decoder = null; this._decoder = null;

598
src/node_crypto.cc

@ -2036,532 +2036,218 @@ Handle<Value> Connection::SetSNICallback(const Arguments& args) {
#endif #endif
void Cipher::Initialize(v8::Handle<v8::Object> target) { void CipherBase::Initialize(Handle<Object> target) {
HandleScope scope; HandleScope scope;
Local<FunctionTemplate> t = FunctionTemplate::New(New); Local<FunctionTemplate> t = FunctionTemplate::New(New);
t->InstanceTemplate()->SetInternalFieldCount(1); t->InstanceTemplate()->SetInternalFieldCount(1);
NODE_SET_PROTOTYPE_METHOD(t, "init", CipherInit); NODE_SET_PROTOTYPE_METHOD(t, "init", Init);
NODE_SET_PROTOTYPE_METHOD(t, "initiv", CipherInitIv); NODE_SET_PROTOTYPE_METHOD(t, "initiv", InitIv);
NODE_SET_PROTOTYPE_METHOD(t, "update", CipherUpdate); NODE_SET_PROTOTYPE_METHOD(t, "update", Update);
NODE_SET_PROTOTYPE_METHOD(t, "final", Final);
NODE_SET_PROTOTYPE_METHOD(t, "setAutoPadding", SetAutoPadding); NODE_SET_PROTOTYPE_METHOD(t, "setAutoPadding", SetAutoPadding);
NODE_SET_PROTOTYPE_METHOD(t, "final", CipherFinal);
target->Set(String::NewSymbol("Cipher"), t->GetFunction()); target->Set(String::NewSymbol("CipherBase"), t->GetFunction());
} }
bool Cipher:: CipherInit(char* cipherType, char* key_buf, int key_buf_len) { Handle<Value> CipherBase::New(const Arguments& args) {
cipher = EVP_get_cipherbyname(cipherType);
if(!cipher) {
fprintf(stderr, "node-crypto : Unknown cipher %s\n", cipherType);
return false;
}
unsigned char key[EVP_MAX_KEY_LENGTH],iv[EVP_MAX_IV_LENGTH];
int key_len = EVP_BytesToKey(cipher, EVP_md5(), NULL,
(unsigned char*) key_buf, key_buf_len, 1, key, iv);
EVP_CIPHER_CTX_init(&ctx);
EVP_CipherInit_ex(&ctx, cipher, NULL, NULL, NULL, true);
if (!EVP_CIPHER_CTX_set_key_length(&ctx, key_len)) {
fprintf(stderr, "node-crypto : Invalid key length %d\n", key_len);
EVP_CIPHER_CTX_cleanup(&ctx);
return false;
}
EVP_CipherInit_ex(&ctx, NULL, NULL,
(unsigned char*)key,
(unsigned char*)iv, true);
initialised_ = true;
return true;
}
bool Cipher::CipherInitIv(char* cipherType,
char* key,
int key_len,
char* iv,
int iv_len) {
cipher = EVP_get_cipherbyname(cipherType);
if(!cipher) {
fprintf(stderr, "node-crypto : Unknown cipher %s\n", cipherType);
return false;
}
/* OpenSSL versions up to 0.9.8l failed to return the correct
iv_length (0) for ECB ciphers */
if (EVP_CIPHER_iv_length(cipher) != iv_len &&
!(EVP_CIPHER_mode(cipher) == EVP_CIPH_ECB_MODE && iv_len == 0)) {
fprintf(stderr, "node-crypto : Invalid IV length %d\n", iv_len);
return false;
}
EVP_CIPHER_CTX_init(&ctx);
EVP_CipherInit_ex(&ctx, cipher, NULL, NULL, NULL, true);
if (!EVP_CIPHER_CTX_set_key_length(&ctx, key_len)) {
fprintf(stderr, "node-crypto : Invalid key length %d\n", key_len);
EVP_CIPHER_CTX_cleanup(&ctx);
return false;
}
EVP_CipherInit_ex(&ctx, NULL, NULL,
(unsigned char*)key,
(unsigned char*)iv, true);
initialised_ = true;
return true;
}
int Cipher::CipherUpdate(char* data,
int len,
unsigned char** out,
int* out_len) {
if (!initialised_) return 0;
*out_len=len+EVP_CIPHER_CTX_block_size(&ctx);
*out= new unsigned char[*out_len];
return EVP_CipherUpdate(&ctx, *out, out_len, (unsigned char*)data, len);
}
int Cipher::SetAutoPadding(bool auto_padding) {
if (!initialised_) return 0;
return EVP_CIPHER_CTX_set_padding(&ctx, auto_padding ? 1 : 0);
}
int Cipher::CipherFinal(unsigned char** out, int *out_len) {
if (!initialised_) return 0;
*out = new unsigned char[EVP_CIPHER_CTX_block_size(&ctx)];
int r = EVP_CipherFinal_ex(&ctx,*out, out_len);
EVP_CIPHER_CTX_cleanup(&ctx);
initialised_ = false;
return r;
}
Handle<Value> Cipher::New(const Arguments& args) {
HandleScope scope; HandleScope scope;
Cipher *cipher = new Cipher(); CipherBase* cipher = new CipherBase(args[0]->IsTrue() ? kCipher : kDecipher);
cipher->Wrap(args.This()); cipher->Wrap(args.This());
return args.This(); return args.This();
} }
Handle<Value> Cipher::CipherInit(const Arguments& args) {
HandleScope scope;
Cipher *cipher = ObjectWrap::Unwrap<Cipher>(args.This());
if (args.Length() <= 1
|| !args[0]->IsString()
|| !(args[1]->IsString() || Buffer::HasInstance(args[1])))
{
return ThrowException(Exception::Error(String::New(
"Must give cipher-type, key")));
}
ASSERT_IS_BUFFER(args[1]);
ssize_t key_buf_len = Buffer::Length(args[1]);
if (key_buf_len < 0) {
Local<Value> exception = Exception::TypeError(String::New("Bad argument"));
return ThrowException(exception);
}
char* key_buf = new char[key_buf_len];
ssize_t key_written = DecodeWrite(key_buf, key_buf_len, args[1], BINARY);
assert(key_written == key_buf_len);
String::Utf8Value cipherType(args[0]);
bool r = cipher->CipherInit(*cipherType, key_buf, key_buf_len);
delete [] key_buf;
if (!r) return ThrowCryptoError(ERR_get_error());
return args.This();
}
Handle<Value> Cipher::CipherInitIv(const Arguments& args) {
Cipher *cipher = ObjectWrap::Unwrap<Cipher>(args.This());
Handle<Value> CipherBase::Init(char* cipher_type,
char* key_buf,
int key_buf_len) {
HandleScope scope; HandleScope scope;
assert(cipher_ == NULL);
if (args.Length() <= 2 cipher_ = EVP_get_cipherbyname(cipher_type);
|| !args[0]->IsString() if (cipher_ == NULL) {
|| !(args[1]->IsString() || Buffer::HasInstance(args[1])) return ThrowError("Unknown cipher");
|| !(args[2]->IsString() || Buffer::HasInstance(args[2])))
{
return ThrowException(Exception::Error(String::New(
"Must give cipher-type, key, and iv as argument")));
}
ASSERT_IS_BUFFER(args[1]);
ssize_t key_len = Buffer::Length(args[1]);
if (key_len < 0) {
Local<Value> exception = Exception::TypeError(String::New("Bad argument"));
return ThrowException(exception);
}
ASSERT_IS_BUFFER(args[2]);
ssize_t iv_len = Buffer::Length(args[2]);
if (iv_len < 0) {
Local<Value> exception = Exception::TypeError(String::New("Bad argument"));
return ThrowException(exception);
}
char* key_buf = new char[key_len];
ssize_t key_written = DecodeWrite(key_buf, key_len, args[1], BINARY);
assert(key_written == key_len);
char* iv_buf = new char[iv_len];
ssize_t iv_written = DecodeWrite(iv_buf, iv_len, args[2], BINARY);
assert(iv_written == iv_len);
String::Utf8Value cipherType(args[0]);
bool r = cipher->CipherInitIv(*cipherType, key_buf,key_len,iv_buf,iv_len);
delete [] key_buf;
delete [] iv_buf;
if (!r) return ThrowCryptoError(ERR_get_error());
return args.This();
}
Handle<Value> Cipher::CipherUpdate(const Arguments& args) {
Cipher *cipher = ObjectWrap::Unwrap<Cipher>(args.This());
HandleScope scope;
ASSERT_IS_BUFFER(args[0]);
unsigned char* out=0;
int out_len=0, r;
char* buffer_data = Buffer::Data(args[0]);
size_t buffer_length = Buffer::Length(args[0]);
r = cipher->CipherUpdate(buffer_data, buffer_length, &out, &out_len);
if (r == 0) {
delete [] out;
return ThrowCryptoTypeError(ERR_get_error());
}
Local<Value> outString;
outString = Encode(out, out_len, BUFFER);
if (out) delete [] out;
return scope.Close(outString);
}
Handle<Value> Cipher::SetAutoPadding(const Arguments& args) {
HandleScope scope;
Cipher *cipher = ObjectWrap::Unwrap<Cipher>(args.This());
cipher->SetAutoPadding(args.Length() < 1 || args[0]->BooleanValue());
return Undefined();
}
Handle<Value> Cipher::CipherFinal(const Arguments& args) {
Cipher *cipher = ObjectWrap::Unwrap<Cipher>(args.This());
HandleScope scope;
unsigned char* out_value = NULL;
int out_len = -1;
Local<Value> outString ;
int r = cipher->CipherFinal(&out_value, &out_len);
if (out_len <= 0 || r == 0) {
delete[] out_value;
out_value = NULL;
if (r == 0) return ThrowCryptoTypeError(ERR_get_error());
} }
outString = Encode(out_value, out_len, BUFFER); unsigned char key[EVP_MAX_KEY_LENGTH];
unsigned char iv[EVP_MAX_IV_LENGTH];
delete [] out_value;
return scope.Close(outString);
}
void Decipher::Initialize(v8::Handle<v8::Object> target) {
HandleScope scope;
Local<FunctionTemplate> t = FunctionTemplate::New(New);
t->InstanceTemplate()->SetInternalFieldCount(1);
NODE_SET_PROTOTYPE_METHOD(t, "init", DecipherInit);
NODE_SET_PROTOTYPE_METHOD(t, "initiv", DecipherInitIv);
NODE_SET_PROTOTYPE_METHOD(t, "update", DecipherUpdate);
NODE_SET_PROTOTYPE_METHOD(t, "final", DecipherFinal);
NODE_SET_PROTOTYPE_METHOD(t, "finaltol", DecipherFinal); // remove someday
NODE_SET_PROTOTYPE_METHOD(t, "setAutoPadding", SetAutoPadding);
target->Set(String::NewSymbol("Decipher"), t->GetFunction());
}
bool Decipher::DecipherInit(char* cipherType, char* key_buf, int key_buf_len) {
cipher_ = EVP_get_cipherbyname(cipherType);
if(!cipher_) {
fprintf(stderr, "node-crypto : Unknown cipher %s\n", cipherType);
return false;
}
unsigned char key[EVP_MAX_KEY_LENGTH],iv[EVP_MAX_IV_LENGTH];
int key_len = EVP_BytesToKey(cipher_, int key_len = EVP_BytesToKey(cipher_,
EVP_md5(), EVP_md5(),
NULL, NULL,
(unsigned char*)(key_buf), reinterpret_cast<unsigned char*>(key_buf),
key_buf_len, key_buf_len,
1, 1,
key, key,
iv); iv);
EVP_CIPHER_CTX_init(&ctx); EVP_CIPHER_CTX_init(&ctx_);
EVP_CipherInit_ex(&ctx, cipher_, NULL, NULL, NULL, false); EVP_CipherInit_ex(&ctx_, cipher_, NULL, NULL, NULL, kind_ == kCipher);
if (!EVP_CIPHER_CTX_set_key_length(&ctx, key_len)) { if (!EVP_CIPHER_CTX_set_key_length(&ctx_, key_len)) {
fprintf(stderr, "node-crypto : Invalid key length %d\n", key_len); EVP_CIPHER_CTX_cleanup(&ctx_);
EVP_CIPHER_CTX_cleanup(&ctx); return ThrowError("Invalid key length");
return false;
} }
EVP_CipherInit_ex(&ctx, NULL, NULL,
(unsigned char*)key,
(unsigned char*)iv, false);
initialised_ = true;
return true;
}
bool Decipher::DecipherInitIv(char* cipherType, EVP_CipherInit_ex(&ctx_,
char* key, NULL,
int key_len, NULL,
char* iv, reinterpret_cast<unsigned char*>(key),
int iv_len) { reinterpret_cast<unsigned char*>(iv),
cipher_ = EVP_get_cipherbyname(cipherType); kind_ == kCipher);
if(!cipher_) {
fprintf(stderr, "node-crypto : Unknown cipher %s\n", cipherType);
return false;
}
/* OpenSSL versions up to 0.9.8l failed to return the correct
iv_length (0) for ECB ciphers */
if (EVP_CIPHER_iv_length(cipher_) != iv_len &&
!(EVP_CIPHER_mode(cipher_) == EVP_CIPH_ECB_MODE && iv_len == 0)) {
fprintf(stderr, "node-crypto : Invalid IV length %d\n", iv_len);
return false;
}
EVP_CIPHER_CTX_init(&ctx);
EVP_CipherInit_ex(&ctx, cipher_, NULL, NULL, NULL, false);
if (!EVP_CIPHER_CTX_set_key_length(&ctx, key_len)) {
fprintf(stderr, "node-crypto : Invalid key length %d\n", key_len);
EVP_CIPHER_CTX_cleanup(&ctx);
return false;
}
EVP_CipherInit_ex(&ctx, NULL, NULL,
(unsigned char*)key,
(unsigned char*)iv, false);
initialised_ = true; initialised_ = true;
return true; return Null();
}
int Decipher::DecipherUpdate(char* data,
int len,
unsigned char** out,
int* out_len) {
if (!initialised_) {
*out_len = 0;
*out = NULL;
return 0;
}
*out_len=len+EVP_CIPHER_CTX_block_size(&ctx);
*out= new unsigned char[*out_len];
return EVP_CipherUpdate(&ctx, *out, out_len, (unsigned char*)data, len);
} }
int Decipher::SetAutoPadding(bool auto_padding) { Handle<Value> CipherBase::Init(const Arguments& args) {
if (!initialised_) return 0; HandleScope scope;
return EVP_CIPHER_CTX_set_padding(&ctx, auto_padding ? 1 : 0);
}
int Decipher::DecipherFinal(unsigned char** out, int *out_len) { CipherBase* cipher = ObjectWrap::Unwrap<CipherBase>(args.This());
int r;
if (!initialised_) { if (args.Length() < 2 ||
*out_len = 0; !(args[0]->IsString() && Buffer::HasInstance(args[1]))) {
*out = NULL; return ThrowError("Must give cipher-type, key");
return 0;
} }
*out = new unsigned char[EVP_CIPHER_CTX_block_size(&ctx)]; String::Utf8Value cipher_type(args[0]);
r = EVP_CipherFinal_ex(&ctx,*out,out_len); char* key_buf = Buffer::Data(args[1]);
EVP_CIPHER_CTX_cleanup(&ctx); ssize_t key_buf_len = Buffer::Length(args[1]);
initialised_ = false;
return r;
}
Handle<Value> Decipher::New(const Arguments& args) { Handle<Value> ret = cipher->Init(*cipher_type, key_buf, key_buf_len);
HandleScope scope;
Decipher *cipher = new Decipher(); if (ret->IsNull()) {
cipher->Wrap(args.This()); return args.This();
return args.This(); } else {
// Exception
return scope.Close(ret);
}
} }
Handle<Value> Decipher::DecipherInit(const Arguments& args) { Handle<Value> CipherBase::InitIv(char* cipher_type,
Decipher *cipher = ObjectWrap::Unwrap<Decipher>(args.This()); char* key,
int key_len,
char* iv,
int iv_len) {
HandleScope scope; HandleScope scope;
if (args.Length() <= 1 cipher_ = EVP_get_cipherbyname(cipher_type);
|| !args[0]->IsString() if (cipher_ == NULL) {
|| !(args[1]->IsString() || Buffer::HasInstance(args[1]))) return ThrowError("Unknown cipher");
{
return ThrowException(Exception::Error(String::New(
"Must give cipher-type, key as argument")));
} }
ASSERT_IS_BUFFER(args[1]); /* OpenSSL versions up to 0.9.8l failed to return the correct
ssize_t key_len = Buffer::Length(args[1]); iv_length (0) for ECB ciphers */
if (EVP_CIPHER_iv_length(cipher_) != iv_len &&
if (key_len < 0) { !(EVP_CIPHER_mode(cipher_) == EVP_CIPH_ECB_MODE && iv_len == 0)) {
Local<Value> exception = Exception::TypeError(String::New("Bad argument")); return ThrowError("Invalid IV length");
return ThrowException(exception); }
} EVP_CIPHER_CTX_init(&ctx_);
EVP_CipherInit_ex(&ctx_, cipher_, NULL, NULL, NULL, kind_ == kCipher);
char* key_buf = new char[key_len]; if (!EVP_CIPHER_CTX_set_key_length(&ctx_, key_len)) {
ssize_t key_written = DecodeWrite(key_buf, key_len, args[1], BINARY); EVP_CIPHER_CTX_cleanup(&ctx_);
assert(key_written == key_len); return ThrowError("Invalid key length");
}
String::Utf8Value cipherType(args[0]);
EVP_CipherInit_ex(&ctx_,
bool r = cipher->DecipherInit(*cipherType, key_buf,key_len); NULL,
NULL,
delete [] key_buf; reinterpret_cast<unsigned char*>(key),
reinterpret_cast<unsigned char*>(iv),
if (!r) { kind_ == kCipher);
return ThrowException(Exception::Error(String::New("DecipherInit error"))); initialised_ = true;
} return Null();
return args.This();
} }
Handle<Value> Decipher::DecipherInitIv(const Arguments& args) { Handle<Value> CipherBase::InitIv(const Arguments& args) {
Decipher *cipher = ObjectWrap::Unwrap<Decipher>(args.This());
HandleScope scope; HandleScope scope;
if (args.Length() <= 2 CipherBase* cipher = ObjectWrap::Unwrap<CipherBase>(args.This());
|| !args[0]->IsString()
|| !(args[1]->IsString() || Buffer::HasInstance(args[1]))
|| !(args[2]->IsString() || Buffer::HasInstance(args[2])))
{
return ThrowException(Exception::Error(String::New(
"Must give cipher-type, key, and iv as argument")));
}
ASSERT_IS_BUFFER(args[1]); if (args.Length() < 3 || !args[0]->IsString()) {
ssize_t key_len = Buffer::Length(args[1]); return ThrowError("Must give cipher-type, key, and iv as argument");
if (key_len < 0) {
Local<Value> exception = Exception::TypeError(String::New("Bad argument"));
return ThrowException(exception);
} }
ASSERT_IS_BUFFER(args[1]);
ASSERT_IS_BUFFER(args[2]); ASSERT_IS_BUFFER(args[2]);
ssize_t iv_len = Buffer::Length(args[2]);
if (iv_len < 0) {
Local<Value> exception = Exception::TypeError(String::New("Bad argument"));
return ThrowException(exception);
}
char* key_buf = new char[key_len];
ssize_t key_written = DecodeWrite(key_buf, key_len, args[1], BINARY);
assert(key_written == key_len);
char* iv_buf = new char[iv_len]; String::Utf8Value cipher_type(args[0]);
ssize_t iv_written = DecodeWrite(iv_buf, iv_len, args[2], BINARY); ssize_t key_len = Buffer::Length(args[1]);
assert(iv_written == iv_len); char* key_buf = Buffer::Data(args[1]);
ssize_t iv_len = Buffer::Length(args[2]);
String::Utf8Value cipherType(args[0]); char* iv_buf = Buffer::Data(args[2]);
bool r = cipher->DecipherInitIv(*cipherType, key_buf,key_len,iv_buf,iv_len);
delete [] key_buf; Handle<Value> ret = cipher->InitIv(*cipher_type,
delete [] iv_buf; key_buf,
key_len,
iv_buf,
iv_len);
if (!r) { if (ret->IsNull()) {
return ThrowException(Exception::Error(String::New("DecipherInitIv error"))); return args.This();
} else {
// Exception
return scope.Close(ret);
} }
}
return args.This();
bool CipherBase::Update(char* data,
int len,
unsigned char** out,
int* out_len) {
if (!initialised_) return 0;
*out_len = len + EVP_CIPHER_CTX_block_size(&ctx_);
*out = new unsigned char[*out_len];
return EVP_CipherUpdate(&ctx_,
*out,
out_len,
reinterpret_cast<unsigned char*>(data),
len);
} }
Handle<Value> Decipher::DecipherUpdate(const Arguments& args) { Handle<Value> CipherBase::Update(const Arguments& args) {
HandleScope scope; HandleScope scope;
Decipher *cipher = ObjectWrap::Unwrap<Decipher>(args.This()); CipherBase* cipher = ObjectWrap::Unwrap<CipherBase>(args.This());
ASSERT_IS_BUFFER(args[0]); ASSERT_IS_BUFFER(args[0]);
ssize_t len; unsigned char* out = NULL;
bool r;
char* buf; int out_len = 0;
// if alloc_buf then buf must be deleted later
bool alloc_buf = false;
char* buffer_data = Buffer::Data(args[0]); char* buffer_data = Buffer::Data(args[0]);
size_t buffer_length = Buffer::Length(args[0]); size_t buffer_length = Buffer::Length(args[0]);
buf = buffer_data; r = cipher->Update(buffer_data, buffer_length, &out, &out_len);
len = buffer_length;
unsigned char* out=0;
int out_len=0;
int r = cipher->DecipherUpdate(buf, len, &out, &out_len);
if (!r) { if (!r) {
delete [] out; delete[] out;
return ThrowCryptoTypeError(ERR_get_error()); return ThrowCryptoTypeError(ERR_get_error());
} }
Local<Value> outString; Buffer* buf = Buffer::New(reinterpret_cast<char*>(out), out_len);
outString = Encode(out, out_len, BUFFER);
if (out) delete [] out; return scope.Close(buf->handle_);
}
if (alloc_buf) delete [] buf;
return scope.Close(outString);
bool CipherBase::SetAutoPadding(bool auto_padding) {
if (!initialised_) return false;
return EVP_CIPHER_CTX_set_padding(&ctx_, auto_padding);
} }
Handle<Value> Decipher::SetAutoPadding(const Arguments& args) { Handle<Value> CipherBase::SetAutoPadding(const Arguments& args) {
HandleScope scope; HandleScope scope;
Decipher *cipher = ObjectWrap::Unwrap<Decipher>(args.This());
CipherBase* cipher = ObjectWrap::Unwrap<CipherBase>(args.This());
cipher->SetAutoPadding(args.Length() < 1 || args[0]->BooleanValue()); cipher->SetAutoPadding(args.Length() < 1 || args[0]->BooleanValue());
@ -2569,26 +2255,39 @@ Handle<Value> Decipher::SetAutoPadding(const Arguments& args) {
} }
Handle<Value> Decipher::DecipherFinal(const Arguments& args) { bool CipherBase::Final(unsigned char** out, int *out_len) {
if (!initialised_) return false;
*out = new unsigned char[EVP_CIPHER_CTX_block_size(&ctx_)];
bool r = EVP_CipherFinal_ex(&ctx_, *out, out_len);
EVP_CIPHER_CTX_cleanup(&ctx_);
initialised_ = false;
return r;
}
Handle<Value> CipherBase::Final(const Arguments& args) {
HandleScope scope; HandleScope scope;
Decipher *cipher = ObjectWrap::Unwrap<Decipher>(args.This()); CipherBase* cipher = ObjectWrap::Unwrap<CipherBase>(args.This());
unsigned char* out_value = NULL; unsigned char* out_value = NULL;
int out_len = -1; int out_len = -1;
Local<Value> outString; Local<Value> outString;
int r = cipher->DecipherFinal(&out_value, &out_len); bool r = cipher->Final(&out_value, &out_len);
if (out_len <= 0 || r == 0) { if (out_len <= 0 || !r) {
delete [] out_value; // allocated even if out_len == 0 delete[] out_value;
out_value = NULL; out_value = NULL;
if (r == 0) return ThrowCryptoTypeError(ERR_get_error()); out_len = 0;
if (!r) return ThrowCryptoTypeError(ERR_get_error());
} }
outString = Encode(out_value, out_len, BUFFER); Buffer* buf = Buffer::New(reinterpret_cast<char*>(out_value), out_len);
delete [] out_value;
return scope.Close(outString); return scope.Close(buf->handle_);
} }
@ -3946,8 +3645,7 @@ void InitCrypto(Handle<Object> target) {
SecureContext::Initialize(target); SecureContext::Initialize(target);
Connection::Initialize(target); Connection::Initialize(target);
Cipher::Initialize(target); CipherBase::Initialize(target);
Decipher::Initialize(target);
DiffieHellman::Initialize(target); DiffieHellman::Initialize(target);
Hmac::Initialize(target); Hmac::Initialize(target);
Hash::Initialize(target); Hash::Initialize(target);

87
src/node_crypto.h

@ -276,79 +276,48 @@ class Connection : ObjectWrap {
friend class SecureContext; friend class SecureContext;
}; };
class Cipher : public ObjectWrap { class CipherBase : public ObjectWrap {
public: public:
static void Initialize (v8::Handle<v8::Object> target); static void Initialize(v8::Handle<v8::Object> target);
bool CipherInit(char* cipherType, char* key_buf, int key_buf_len);
bool CipherInitIv(char* cipherType,
char* key,
int key_len,
char* iv,
int iv_len);
int CipherUpdate(char* data, int len, unsigned char** out, int* out_len);
int SetAutoPadding(bool auto_padding);
int CipherFinal(unsigned char** out, int *out_len);
protected: protected:
static v8::Handle<v8::Value> New(const v8::Arguments& args); enum CipherKind {
static v8::Handle<v8::Value> CipherInit(const v8::Arguments& args); kCipher,
static v8::Handle<v8::Value> CipherInitIv(const v8::Arguments& args); kDecipher
static v8::Handle<v8::Value> CipherUpdate(const v8::Arguments& args); };
static v8::Handle<v8::Value> SetAutoPadding(const v8::Arguments& args);
static v8::Handle<v8::Value> CipherFinal(const v8::Arguments& args);
Cipher() : ObjectWrap(), initialised_(false) {
}
~Cipher() {
if (initialised_) {
EVP_CIPHER_CTX_cleanup(&ctx);
}
}
private:
EVP_CIPHER_CTX ctx; /* coverity[member_decl] */
const EVP_CIPHER *cipher; /* coverity[member_decl] */
bool initialised_;
};
class Decipher : public ObjectWrap {
public:
static void Initialize(v8::Handle<v8::Object> target);
bool DecipherInit(char* cipherType, char* key_buf, int key_buf_len); v8::Handle<v8::Value> Init(char* cipher_type, char* key_buf, int key_buf_len);
bool DecipherInitIv(char* cipherType, v8::Handle<v8::Value> InitIv(char* cipher_type,
char* key, char* key,
int key_len, int key_len,
char* iv, char* iv,
int iv_len); int iv_len);
int DecipherUpdate(char* data, int len, unsigned char** out, int* out_len); bool Update(char* data, int len, unsigned char** out, int* out_len);
int SetAutoPadding(bool auto_padding); bool Final(unsigned char** out, int *out_len);
int DecipherFinal(unsigned char** out, int *out_len); bool SetAutoPadding(bool auto_padding);
protected:
static v8::Handle<v8::Value> New(const v8::Arguments& args); static v8::Handle<v8::Value> New(const v8::Arguments& args);
static v8::Handle<v8::Value> DecipherInit(const v8::Arguments& args); static v8::Handle<v8::Value> Init(const v8::Arguments& args);
static v8::Handle<v8::Value> InitIv(const v8::Arguments& args);
static v8::Handle<v8::Value> DecipherInitIv(const v8::Arguments& args); static v8::Handle<v8::Value> Update(const v8::Arguments& args);
static v8::Handle<v8::Value> DecipherUpdate(const v8::Arguments& args); static v8::Handle<v8::Value> Final(const v8::Arguments& args);
static v8::Handle<v8::Value> SetAutoPadding(const v8::Arguments& args); static v8::Handle<v8::Value> SetAutoPadding(const v8::Arguments& args);
static v8::Handle<v8::Value> DecipherFinal(const v8::Arguments& args);
Decipher() : ObjectWrap(), initialised_(false) { CipherBase(CipherKind kind) : cipher_(NULL),
initialised_(false),
kind_(kind) {
} }
~Decipher() { ~CipherBase() {
if (initialised_) { if (!initialised_) return;
EVP_CIPHER_CTX_cleanup(&ctx); EVP_CIPHER_CTX_cleanup(&ctx_);
}
} }
private: private:
EVP_CIPHER_CTX ctx; EVP_CIPHER_CTX ctx_; /* coverity[member_decl] */
const EVP_CIPHER *cipher_; const EVP_CIPHER* cipher_; /* coverity[member_decl] */
bool initialised_; bool initialised_;
CipherKind kind_;
}; };
class Hmac : public ObjectWrap { class Hmac : public ObjectWrap {

Loading…
Cancel
Save