Browse Source

https: don't overwrite servername option

PR-URL: https://github.com/iojs/io.js/pull/1110
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
v1.8.0-commit
skenqbx 10 years ago
committed by Fedor Indutny
parent
commit
8453fbc879
  1. 2
      lib/_http_agent.js
  2. 40
      test/parallel/test-https-agent-servername.js

2
lib/_http_agent.js

@ -160,6 +160,7 @@ Agent.prototype.createSocket = function(req, options) {
options = util._extend({}, options); options = util._extend({}, options);
options = util._extend(options, self.options); options = util._extend(options, self.options);
if (!options.servername) {
options.servername = options.host; options.servername = options.host;
if (req) { if (req) {
var hostHeader = req.getHeader('host'); var hostHeader = req.getHeader('host');
@ -167,6 +168,7 @@ Agent.prototype.createSocket = function(req, options) {
options.servername = hostHeader.replace(/:.*$/, ''); options.servername = hostHeader.replace(/:.*$/, '');
} }
} }
}
var name = self.getName(options); var name = self.getName(options);

40
test/parallel/test-https-agent-servername.js

@ -0,0 +1,40 @@
var common = require('../common');
var assert = require('assert');
if (!common.hasCrypto) {
console.log('1..0 # Skipped: missing crypto');
process.exit();
}
var https = require('https');
var fs = require('fs');
var options = {
key: fs.readFileSync(common.fixturesDir + '/keys/agent1-key.pem'),
cert: fs.readFileSync(common.fixturesDir + '/keys/agent1-cert.pem'),
ca: fs.readFileSync(common.fixturesDir + '/keys/ca1-cert.pem')
};
var server = https.Server(options, function(req, res) {
res.writeHead(200);
res.end('hello world\n');
});
server.listen(common.PORT, function() {
https.get({
path: '/',
port: common.PORT,
rejectUnauthorized: true,
servername: 'agent1',
ca: options.ca
}, function(res) {
res.resume();
console.log(res.statusCode);
server.close();
}).on('error', function(e) {
console.log(e.message);
process.exit(1);
});
});
Loading…
Cancel
Save