Browse Source

doc: don't suggest setEncoding for binary streams

Removed an incorrect reference to the use of setEncoding(null) as the
proper way to handling binary streams or to disable encoding, and
explained that the default encoding is "no encoding", and that this is
the correct approach for dealing with binary data via Buffers.

PR-URL: https://github.com/nodejs/node/pull/11363
Fixes: https://github.com/nodejs/node/issues/11352
Refs: https://github.com/nodejs/node/issues/11316
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
v6
Rick Bullotta 8 years ago
committed by Gibson Fahnestock
parent
commit
847688018c
No known key found for this signature in database GPG Key ID: B01FBB92821C587A
  1. 13
      doc/api/stream.md

13
doc/api/stream.md

@ -920,13 +920,14 @@ added: v0.9.4
* `encoding` {string} The encoding to use. * `encoding` {string} The encoding to use.
* Returns: `this` * Returns: `this`
The `readable.setEncoding()` method sets the default character encoding for The `readable.setEncoding()` method sets the character encoding for
data read from the Readable stream. data read from the Readable stream.
Setting an encoding causes the stream data By default, no encoding is assigned and stream data will be returned as
to be returned as string of the specified encoding rather than as `Buffer` `Buffer` objects. Setting an encoding causes the stream data
to be returned as strings of the specified encoding rather than as `Buffer`
objects. For instance, calling `readable.setEncoding('utf8')` will cause the objects. For instance, calling `readable.setEncoding('utf8')` will cause the
output data will be interpreted as UTF-8 data, and passed as strings. Calling output data to be interpreted as UTF-8 data, and passed as strings. Calling
`readable.setEncoding('hex')` will cause the data to be encoded in hexadecimal `readable.setEncoding('hex')` will cause the data to be encoded in hexadecimal
string format. string format.
@ -934,10 +935,6 @@ The Readable stream will properly handle multi-byte characters delivered through
the stream that would otherwise become improperly decoded if simply pulled from the stream that would otherwise become improperly decoded if simply pulled from
the stream as `Buffer` objects. the stream as `Buffer` objects.
Encoding can be disabled by calling `readable.setEncoding(null)`. This approach
is useful when working with binary data or with large multi-byte strings spread
out over multiple chunks.
```js ```js
const readable = getReadableStreamSomehow(); const readable = getReadableStreamSomehow();
readable.setEncoding('utf8'); readable.setEncoding('utf8');

Loading…
Cancel
Save