Browse Source

async_hooks: require parameter in emitBefore

Using asyncId as the default triggerAsyncId is wrong. The triggerAsyncId
can actually never be the asyncId.

PR-URL: https://github.com/nodejs/node/pull/14050
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
v6
Andreas Madsen 8 years ago
parent
commit
84f9261efd
No known key found for this signature in database GPG Key ID: 2FEE61B3C9E40F20
  1. 2
      lib/async_hooks.js

2
lib/async_hooks.js

@ -377,7 +377,7 @@ function emitHookFactory(symbol, name) {
// Usage: emitBeforeS(asyncId[, triggerAsyncId]). If triggerAsyncId is omitted
// then asyncId will be used instead.
function emitBeforeS(asyncId, triggerAsyncId = asyncId) {
function emitBeforeS(asyncId, triggerAsyncId) {
// CHECK(Number.isSafeInteger(asyncId) && asyncId > 0)
// CHECK(Number.isSafeInteger(triggerAsyncId) && triggerAsyncId > 0)

Loading…
Cancel
Save